Flight 2 and 3 Firework Rockets counted as Flight 1 Firework Rocket

Aperta
  • Qualcosa non va?
#8,871 4 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
58/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
java
Ambito
game-dev

Direzione di ricerca

The report is that type of flight 2 firework rocket and type of flight 3 firework rocket both print as flight 1. Start from Skript item-type / alias handling for firework rockets (aliases and the code that maps Bukkit firework flight duration into an ItemType name). Reproduce with the /test command in the issue, then adjust naming so flight duration is part of the type string and confirm all three lines print the matching flight.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

waiting for reply
Skript/Server Version
[13:40:24 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[13:40:24 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[13:40:24 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[13:40:24 INFO]: [Skript] Server Version: 26.2-121-a2a42c5 (MC: 26.2)
[13:40:24 INFO]: [Skript] Skript Version: 2.16.1 (skriptlang-github)
[13:40:24 INFO]: [Skript] Installed Skript Addons: 
[13:40:24 INFO]: [Skript]  - skript-placeholders v1.7.1 (https://github.com/APickledWalrus/skript-placeholders)
[13:40:24 INFO]: [Skript]  - DiSky v4.29.0
[13:40:24 INFO]: [Skript]  - Lusk v1.3.14 (https://github.com/JakeGBLP/Lusk)
[13:40:24 INFO]: [Skript]  - skript-reflect v2.6.3 (https://github.com/SkriptLang/skript-reflect)
[13:40:24 INFO]: [Skript]  - SkBee v3.25.4 (https://github.com/ShaneBeee/SkBee)
[13:40:24 INFO]: [Skript]  - Skript-LuckPerms v1.0.3
[13:40:24 INFO]: [Skript]  - Skonic v1.2.8
[13:40:24 INFO]: [Skript] Installed dependencies: 
[13:40:24 INFO]: [Skript]  - Vault v1.7.3-b131
[13:40:24 INFO]: [Skript]  - WorldGuard v7.0.17+2370-e42d8bc
[13:40:24 INFO]: [Skript]  - GriefPrevention v16.18.7
Bug Description

Getting the itemtype of flight 2 and 3 firework rockets says flight 1 firework rocket, while it should be flight 2/3 firework rocket.

Expected Behavior

The itemtype of flight 2 and 3 firework rockets should be flight 2/3 firework rocket.

Steps to Reproduce

Try getting the itemtype of flight 2 and 3 firework rockets.

The following code can be used to reproduce it:
command /test:
trigger:
send type of flight 1 firework rocket
send type of flight 2 firework rocket
send type of flight 3 firework rocket

Image
Errors or Screenshots

No response

Other

No response

Agreement
  • I have read the guidelines above and affirm I am following them with this report.
Lingua principale
Java
Stelle
1.3k
Fork
456
Merge medio
4g 14h
PR unite (30g)
6

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di SkriptLang/Skript

Tutte le issue di SkriptLang/Skript

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.