Player Tests

Aperta
  • Qualcosa non va?
#8,710 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Tranquilla
Stack tecnologico
java
Ambito
testing

Direzione di ricerca

Start by reading the existing quicktest flow and the JUnit events that use a mock player; the issue does not name specific files or tests. Work out how player tests would pause for a player to join and how they would fit into normal quicktest or a separate build. Done means player-dependent syntax can be exercised on the test server and failures are reported.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

priority: lowest suggestion
Suggestion

Currently, Skript has 0 tests for effects/expressions you name it that need an online player object with the only exception being events in junit using a mockplayer of sorts

this opens up a load of possible issues as expected as if a pr breaks even a specific part of a player related syntax (eg when resetting it) no one will know unless the syntax is tested before a snapshot/release which is unlikely

My idea is to implement player tests:
These tests would simply be some custom test with player eg:

player test "feed player":
     set saturation of test-player to 5
     feed test-player by 5
     assert saturation of test-player is 10 with "Failed to feed player"

These tests would simply work like this:
Either a custom build for player tests that have player tests + normal tests
or just build it into normal quicktest

the functionality would be simple: Testing process would be paused giving a message that 'Player tests need to be ran. Please join the test server at and wait a few minutes until the tests complete.'

Why?

Explained above (this opens up a load of possible issues as expected as if a pr breaks even a specific part of a player related syntax (eg when resetting it) no one will know unless the syntax is tested before a snapshot/release which is unlikely)

Other

No response

Agreement
  • I have read the guidelines above and affirm I am following them with this suggestion.
Lingua principale
Java
Stelle
1.3k
Fork
456
Merge medio
4g 14h
PR unite (30g)
6

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di SkriptLang/Skript

Tutte le issue di SkriptLang/Skript

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.