PSY parsing changes post package split

Aperta
  • Qualcosa non va?
#54 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 3 giorni

@luke-kiernan ci sta già lavorando.

Dal 19/10/2026.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
julia
Ambito
data

Direzione di ricerca

Start by comparing the referenced PSY commits with PFFP's _gen_base_and_limits and the VSC component parsing model. Verify that base_conversion reaches all ramp-limit branches and determine how REMOT/RMPCT map to the proposed fields, while checking PSY issue #1774 before changing structs. Done means the confirmed parsing divergences are ported without altering the intentional switched-shunt or network-reduction behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

I had Claude audit the commit history of PSY's main for parsing changes that didn't make their way into PFFP.

There were a few things that clearly looked like bugfixes, so I ported them over: #51, #52, and #53 .

Probably should be ported over:

  • 5b298a811 / f5e9f0dd4: PFFP's ramp_limits ignores base_conversion. Its docstring calls this out as a deliberate verbatim port of PSCB's inconsistency. PSY has since ruled it a bug and threads base_conversion through all four branches. Every other limit in _gen_base_and_limits is scaled, so ramp limits are the lone unscaled quantity whenever mbase != sys_mbase.
  • b3542ea98 / 297a4759e: PSY moved VSC control modes to VSCDCControlModes/VSCACControlModes enums and promoted REMOT/RMPCT to first-class remote_bus_control_*/rmpct_* fields. PFFP keeps booleans and drops REMOT/RMPCT entirely. Different component model — but if you want VSC remote-regulation round-tripping, those two fields are simply absent today.

Divergences in behavior that look intentional:

  • cb8ed3363 / 36a33acd0: PSY zeroes switched-shunt initial_status for MODSW ∈ (0,1,2) in all versions. PFFP reworked this — unconditional for pre-v35, actual S1..S8 for v35. PFFP's looks more correct; noting it because the behaviors genuinely differ for v35.
  • 624516aec / cc34620d5 / 0cf823e18 / cca947511 / e7e8b6639: the branch_type_override / network-reduction feature set. PSY-only, no PFFP counterpart.

Strikethough on the first one: component behavior is tied up in this one, too. See PSY #1774: once those struct changes land, we should check back on the parsing situation here.

Lingua principale
Julia
Stelle
1
Fork
3
Merge medio
4g 10h
PR unite (30g)
10

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Sienna-Platform/PowerFlowFileParser.jl

Tutte le issue di Sienna-Platform/PowerFlowFileParser.jl

Issue simili

Altre issue su Julia

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.