[Bug]: `shopify hydrogen dev` exits before listening when the npm registry is unreachable (p-cancelable onCancel-after-settle in latest-version chunk)
I maintainer di solito rispondono entro 2 giorni
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 48/100
- Tipo di issue
- Bug
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- node.js, typescript
- Ambito
- cli
Direzione di ricerca
Inizia da getLatestNPMPackageVersion in dist/chunk-GW4JHUIA.js e segui il relativo chiamante checkForNewVersionOnCLI in dist/chunk-IF6EYTHG.js, incluso il percorso Hydrogen in dist/chunk-IF6EYTHG.js. Riproduci il problema con l'accesso a npm-registry bloccato; il lavoro è completato quando shopify hydrogen dev continua a essere eseguito e raggiunge l'output di ascolto locale senza un errore p-cancelable non gestito.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Please confirm that you have:
- Searched existing issues to see if your issue is a duplicate.
- Reproduced the issue in the latest CLI version.
In which of these areas are you experiencing a problem?
Hydrogen custom storefront
Expected behavior
shopify hydrogen dev starts the dev server. The startup "is there a newer version?" check is a
courtesy; if the npm registry is unreachable it should degrade to a debug log and the server should
still come up.
Actual behavior
When the npm registry is unreachable, shopify hydrogen dev exits 1 before the dev server ever
listens. No ➜ Local: line is printed. The process dies with p-cancelable's internal invariant:
> shopify hydrogen dev --codegen --port "$PORT"
The `envFile` option is deprecated, please use `envDir: false` instead.
[vite] (ssr) Re-optimizing dependencies because vite config has changed
[vite] (client) Re-optimizing dependencies because vite config has changed
Error: The `onCancel` handler was attached after the promise settled.
at o (node_modules/@shopify/cli/dist/latest-version-LDWU5F7A.js:11:17603)
at d (node_modules/@shopify/cli/dist/latest-version-LDWU5F7A.js:19:47843)
at t.<anonymous> (node_modules/@shopify/cli/dist/latest-version-LDWU5F7A.js:19:49069)
at t.wrapper (node:events:639:12)
at t.emit (node:events:514:20)
at t.emit (node:domain:473:12)
at node_modules/@shopify/cli/dist/latest-version-LDWU5F7A.js:19:37968
at runNextTicks (node:internal/process/task_queues:65:5)
at processTimers (node:internal/timers:615:9)
This is a hard startup failure, not a degraded notification.
Reproduction steps
- Scaffold or use any Hydrogen storefront;
npm ciwith network sonode_modulesis complete. - Remove npm-registry reachability. Any of these reproduce it: firewall
DROP, firewall
REJECT/ECONNREFUSED, or refusing DNS. npm run dev(i.e.shopify hydrogen dev).
Exits 1 with the trace above. Reproduced on Node 26.8.2 / npm 11.19.1, Debian trixie (node:26-slim),
linux/arm64 and linux/amd64.
Analysis
From the shipped bundle of 4.7.1:
latest-version-*.js is dynamically imported from exactly one place — getLatestNPMPackageVersion
in dist/chunk-GW4JHUIA.js:
async function ne(e) { // getLatestNPMPackageVersion
return d(s`Getting the latest version of NPM package: ${c.raw(e)}`),
y("cmd_all_timing_network_ms")(async () => {
const { default: n } = await import("./latest-version-LDWU5F7A.js");
return n(e);
});
}
whose only caller is checkForNewVersionOnCLI, which already wraps it defensively:
async function Pe(e, n, { cacheExpiryInHours: a = 0 } = {}) { // checkForNewVersionOnCLI
const t = async () => (d(s`Checking if there's a version of ${e} newer than ${n}`), ne(e));
let p;
try { p = await O(`npm-package-${e}`, t, a * 3600 * 1000); } catch { return; }
if (p && new SemVer(n).compare(p) < 0) return p;
}
The try/catch cannot help. The thrown error is p-cancelable's guard in its own constructor:
const o = a => {
if (!this._isPending) throw new Error("The `onCancel` handler was attached after the promise settled.");
this._cancelHandlers.push(a);
};
and the stack bottoms out in processTimers → runNextTicks, reaching node:domain. So the throw
originates from a timer callback firing after the awaited promise already settled — outside the
await, therefore outside the catch. It escapes as an uncaught exception and terminates the
process. latest-version-*.js contains 22 setTimeout and 1 setInterval.
checkForNewVersionOnCLI has two callers in the bundle: the auto-upgrade path
(dist/chunk-4FI2YBRF.js) and Hydrogen's own version check in dist/chunk-IF6EYTHG.js. The latter
is the one that reaches hydrogen dev, and its only early-outs are a module-level flag and
next/experimental/snapshot version strings.
Notably not workarounds
Each measured, not assumed:
CI=1— no effect. The CI check inversionToAutoUpgradesits after the lookup and governs a
different function; the Hydrogen-side caller has no CI guard at all.- Refusal vs. black-holing — no effect. With
nftables reject with tcp resetreturning
ECONNREFUSEDin 3 ms (kernel counters confirmed non-zero after the run), the crash is
byte-identical to a silentdrop. Settle timing is not the variable; a stale timer is. - Upgrading the CLI — no effect.
dist/latest-version-LDWU5F7A.jsis byte-identical
(sha256c493bb882df5b786…) across 4.6.1, 4.7.1, 4.8.0, and the 2026-09-14 nightly. - Env opt-out — none exists. All 42
SHOPIFY_CLI_*variables in the bundle were inventoried;
SHOPIFY_CLI_FORCE_AUTO_UPGRADEonly forces the upgrade, andautoUpgradeEnabledlives in the
conf store rather than the environment.
Impact
Any environment that runs a Hydrogen dev server without npm-registry egress cannot start the
storefront at all: CI sandboxes, offline development, and restricted-egress hosting. In our case the
dev server runs under a deliberately locked-down egress policy, so this is unconditional.
Suggested fix
Make the version check unable to reject into the process. Either attach the onCancel handler
synchronously during construction (before any await), or defensively guard the registration:
if (promise.isPending) promise.onCancel(...)
and clear the pending timers when the request settles or aborts. An explicit opt-out
(SHOPIFY_CLI_SKIP_VERSION_CHECK=1) would also let restricted environments avoid the network call
entirely.
Operating System
Debian GNU/Linux 13 (trixie), containerized; reproduced on both arm64 and amd64.
Shopify CLI version
4.7.1 (chunk identical in 4.6.1, 4.8.0, nightly)
Node version
26.8.2
- Lingua principale
- TypeScript
- Stelle
- 750
- Fork
- 293
- Merge medio
- 3g 5h
- PR unite (30g)
- 102
Preparare l'ambiente
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di Shopify/cli
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
Shopify/cli#8388 · 3 commenti ·
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 42/100
Shopify/cli#8386 · 26 commenti · 33 reazioni ·
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 15/100
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 15/100
I maintainer di solito rispondono entro 2 giorni
Issue simili
-
Difficoltà 1/5 1-3 ore Idoneità per principianti 88/100
supabase/agent-skills#611 ·
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 68/100
polka-codes/test#345 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 1-3 ore Idoneità per principianti 92/100
GoogleChromeLabs/project-sesame#217 ·
I maintainer di solito rispondono entro 12 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
solana-foundation/solana-com#2202 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100