The docs hero is sometimes drawn before the system pill's first reading

Aperta
#802 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
56/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
macos, swift
Ambito
desktop, testing

Direzione di ricerca

Start with Sources/StableBar/DocsImages.swift, especially DocsImages.snapshot and its readiness check, then trace how the system widget’s first output reaches the bar presentation. Reproduce with taskpolicy -b StableBar --render-docs-images DIR and compare repeated docs/hero-dark renders. Done when every widget shows its sample output before capture and repeated renders produce the same pixels.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

What happens

docs/hero-dark is sometimes drawn before the system pill's first reading reaches the bar. The pill then shows … and …% instead of the sample's 18% and 54%. The pill is narrower, so the bar's right end and the calendar popup under it sit further right than in a good drawing.

When it happens in Draw main's screens, every pull request based on that commit gets a false changed screen in its before/after comparison. A maintainer has to tell it apart from a real change before adding visual-ok. The Docs images job draws the same image, so a stable release could also commit a README hero showing … …%.

Steps to reproduce

Seen on CI only, twice so far (2026-11-01 and 2026-11-18):

  1. A push to main runs Draw main's screens (StableBar --render-docs-images).
  2. A pull request based on that commit draws its own docs images and compares them with main's.
  3. One side's hero-dark has … …% in the system pill; the other side has 18% and 54%.

taskpolicy -b StableBar --render-docs-images DIR, run a few times, may reproduce it locally by slowing the drawing down.

Expected

The docs images wait until every widget on the bar shows its sample output, so two runs of one commit draw the same pixels, as CONTRIBUTING's Docs images section says they do.

Environment

CI, macos-26 runner (Apple silicon, 3 cores), Xcode 26.6. main at 937c40e.

Evidence

Diagnosis

  • DocsImages.render draws the hero from sampleStore(…) (Sources/StableBar/DocsImages.swift). Its system-monitor widget is the "type": "system" widget setup adds (SetupPreferences.WidgetSet.system). The sample configuration defines a system command provider that runs /bin/cat "$CONFIG_DIR/system.json", with interval: 3600.
  • DocsImages.snapshot passes OffscreenSnapshot.write a readiness check and a fixed 3-second settle. The check waits until the sample workspaces exist and no store.scripts entry has outputNumber == 0.
  • The bad drawing shows the pill's placeholders, so that check, or the settle after it, didn't cover the pill's first reading. Either the system widget's output isn't among the store.scripts entries the check reads, or the reading arrived but the bar hadn't shown it within the settle on a busy runner. Which one is unverified.
  • A fix would wait on what the bar shows for each widget, for example its presentation having received an output, rather than on the time a settle allows.

Related

  • #395 made the docs images draw the same on every run (fixed date, offline Store, sample app). This is a remaining source of difference between runs.
  • #432 noticed the same difference in its description, but no issue was filed.
  • #794 (draft) found the same kind of race in scenes, where a fixed settle ends before a view's data loads. This one is in the docs images and happens without parallel drawing.

Triaged by Claude Code (Claude Opus 5.5).

Lingua principale
Swift
Stelle
184
Fork
12
Merge medio
3h 50m
PR unite (30g)
387

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Seb-GRAF/StableBar

Tutte le issue di Seb-GRAF/StableBar

Issue simili

Altre issue su Swift

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.