Check updates before unpacking them and sign the update feed, once a release carries the EdDSA key

Aperta
#537 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
macos, swift
Ambito
desktop, release

Direzione di ricerca

Read #335 and the signing section of CONTRIBUTING, then inspect Resources/Info.plist and scripts/package.sh. First confirm that a stable release carrying SUPublicEDKey has shipped and that the rolling appcast release signs appcast.xml and release notes as described. Enable the Sparkle settings at the stated release milestones, update CONTRIBUTING, and verify the published feed signatures.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

Problem

#335 adds an EdDSA key to the app (SUPublicEDKey) and signs every new update in the feed with it. Two Sparkle settings that need that key stay off:

  • Sparkle unpacks the download before checking it. SUVerifyUpdateBeforeExtraction (Sparkle 2.7.3+) checks the archive's EdDSA signature first.
  • The appcast and its release notes aren't signed. SURequireSignedFeed (Sparkle 2.9+) makes the app refuse a feed that isn't signed with the key.

#335 left both for later on purpose: they should wait until a release with the key has shipped and signed updates have been seen working from the feed. StableBar is on Sparkle 2.10.0, which supports both.

Proposal

  1. Once a stable release with SUPublicEDKey has shipped, add SUVerifyUpdateBeforeExtraction to Resources/Info.plist. Changing the key later still works: when the old key doesn't match, Sparkle then checks the archive's Developer ID team instead, and scripts/package.sh signs the DMG with the Developer ID.
  2. Add SURequireSignedFeed if generate_appcast signs appcast.xml from the rolling appcast release. Its help says it signs the appcast and release notes when an update in it requires a signed feed, so a beta with the setting should show the signature in the published feed before a stable release carries it. From then on, every published feed must be signed.
  3. Update the signing section of CONTRIBUTING.

Possible today

No. Sparkle checks the archive only after unpacking it, and the feed has no signature.

Related

  • #335 adds the key and the per-update signatures; its proposal lists this as step 4.
  • #100 shipped updates trusted through the Developer ID alone, and #22 had planned the EdDSA key.

Triaged by Claude Code (Claude Opus 5.5).

Lingua principale
Swift
Stelle
184
Fork
12
Merge medio
3h 50m
PR unite (30g)
387

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Seb-GRAF/StableBar

Tutte le issue di Seb-GRAF/StableBar

Issue simili

Altre issue su Swift

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.