node-forge GPL-2.0 dual-license causes BlackDuck policy violations via @sap-cloud-sdk/connectivity → jks-js

Aperta
#7,018 0 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@gpretto ci sta già lavorando.

Dal 5/11/2026.

  • #7061 di @davidkna-sap — aperta

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
30/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
node.js, typescript
Ambito
security, tooling

Direzione di ricerca

Start by tracing how @sap-cloud-sdk/connectivity brings in jks-js and where the JKS certificate path is loaded. Compare the proposed options, including whether JKS support can be made opt-in without breaking existing consumers. Done means downstream users no longer encounter the described BlackDuck policy violation while supported JKS behavior is preserved.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

dependencies question

Problem

@sap-cloud-sdk/connectivity pulls in [email protected], which depends on
[email protected]. The node-forge package is dual-licensed as
(BSD-3-Clause OR GPL-2.0).

Enterprise BlackDuck compliance policies routinely block any package whose
SPDX expression includes GPL-2.0, even when a permissive alternative
(BSD-3-Clause) is available in the same expression. This causes our SAP BTP
CAP project to fail the BlackDuck detectExecuteScan pipeline step with
FAILURE_POLICY_VIOLATION.

Dependency chain

@sap-cloud-sdk/[email protected]
└── [email protected]
└── [email protected] ← (BSD-3-Clause OR GPL-2.0)

Impact

  • [email protected] is already the latest release — there is no newer
    version to upgrade to.
  • No npm overrides workaround is possible because the entire chain
    (jks-js → node-forge) is controlled by @sap-cloud-sdk/connectivity.
  • Every project using @sap-cloud-sdk/connectivity (and by extension
    @sap-cloud-sdk/http-client, which depends on it) is affected.

Suggested resolution

One of the following would resolve the violation for all downstream consumers:

  1. Replace jks-js with a BSD-only JKS parser (e.g. rewrite the small
    JKS-parsing surface using Node.js built-in crypto or a package with a
    clean BSD/MIT license).
  2. Make the JKS certificate path opt-in — lazy-require jks-js only
    when a JKS keystore is actually configured, so projects that authenticate
    purely via JWT/mTLS without JKS stores do not pull in node-forge.
  3. Work with the node-forge maintainers to clarify or relicense to
    BSD-3-Clause only, removing the GPL-2.0 dual option.

Environment

Item Version
@sap-cloud-sdk/connectivity 4.9.1
@sap-cloud-sdk/http-client 4.9.1
jks-js 1.1.7
node-forge 1.4.0
Node.js runtime BTP CAP (Node.js 22)
Lingua principale
TypeScript
Stelle
221
Fork
79
Merge medio
13h 27m
PR unite (30g)
22

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di SAP/cloud-sdk-js

Tutte le issue di SAP/cloud-sdk-js

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.