env-var usage analyzer: fallback judged by the first occurrence, CI-provided variables flagged, URLs counted twice

Aperta
#433 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
42/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
devtools

Direzione di ricerca

Start with environment-variables-usage-configuration.ts around lines 27, 57, 174–185, then read git-law-base.ts around lines 78–90 and environment-files-analyzer-validation.ts around lines 59 and 105. The issue describes several analyzer behaviors to investigate; identify the relevant tests or add focused coverage for each. Done when variable handling, CI-provided variables, URL counting, and missing .env.example findings match the suggested direction.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Found in the 8.0.0 self-audit triage: RoC 7.29.1 (npm, 5fc54afe) on a clean clone of develop at 2d2fa9a, with typescript resolvable (verdict compliance, 0 failed / 46 warnings). The bucket method and per-law tables are kept by QA; counts are from that run.

What happens

EnvironmentVariablesUsageAnalyzer (shared by Environment Security and Environment Parity, so every finding is counted in both laws):

  • the fallback window for every occurrence of a variable is taken at content.indexOf(match) — 50 chars before, 100 after the first occurrence (environment-variables-usage-configuration.ts:174-177);
  • "fallback" is a substring search for ||, ??, ? , default (:27, :185); real handling such as candidate?.trim(); if (!name) continue; or process.env.NODE_ENV !== 'production' is not recognised (git-law-base.ts:78-90 reads CI branch variables and skips undefined);
  • three overlapping URL regexes (:57) report one quoted URL twice (bare host and full string); doc-reference URLs count as endpoints;
  • .env.example missing is reported by two analyzers (environment-files-analyzer-validation.ts:59 and :105).

Suggested direction

Judge each process.env.X read at its own offset, ideally from the AST, and treat ?., ??, ||, comparisons and truthiness guards as handled; do not report well-known CI-provided variables as missing fallbacks; one URL pass de-duplicated by position; one .env.example finding.

Lingua principale
TypeScript
Stelle
0
Fork
0
Merge medio
38m
PR unite (30g)
96

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Rule-Of-Code/RoC

Tutte le issue di Rule-Of-Code/RoC

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.