Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

fix(marketplace): release builds ship the mock catalog and mock installs write to the real extensions folder

Aperta
  • Qualcosa non va?
#1,568 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
43/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
dart, flutter
Ambito
desktop, devtools

Direzione di ricerca

Start with lib/core/market/marketplace_repository.dart and inspect the mock repository, ExtensionPaths.extensionsDirectory(), and where the Extension Manager is wired at startup; the issue also points to the generated theme around line 278. Check the related install-path issues #1560 and #1562 and the Beta epic #1499 for scope. Done means release builds cannot present mock installs as real or write them into the extensions folder, and the generated theme name is fixed.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug marketplace P2 ux

Problem

MarketplaceRepository.instance defaults to MockMarketplaceRepository() (lib/core/market/marketplace_repository.dart:27), and HttpMarketplaceRepository is constructed nowhere in lib/ (only in tests). So the release app's Extension Manager shows and installs a hard-coded demo catalog:

  • 6 fake listings (ClickHouse / Redis / MongoDB / "postgres-exporter" drivers, two themes), some tagged official, with cdn.queryahub.com URLs and fake checksums (e3b0c442...b855 is the SHA-256 of an empty string). Nothing in the UI says the catalog is a demo; the only badge is "Preview" for drivers.
  • Search and "download" are Future.delayed loops that fake progress.
  • Install writes to the user's real extensions folder (ExtensionPaths.extensionsDirectory()): a manifest-only directory, and for themes a generated theme.json. These persist across updates and show as installed extensions.
  • Bug in the generated theme (:278): the template is a non-raw '''...''' string containing "\${manifest.name}". \$ escapes the interpolation, so every generic mock theme is literally named ${manifest.name}.

CHANGELOG lists "Planned 0.5.0 — live Marketplace download and install", so the mock is intentional, but it should not reach users this way.

Fix

  • Until the live API ships: in release builds either hide the Marketplace tab (keep Install from file), or show an explicit "Demo catalog, nothing is downloaded" banner and make Install a no-op that does not touch the extensions folder.
  • Choose the repository by build/config (kDebugMode or a dart-define with the API base URL) in one place at startup; move MockMarketplaceRepository and its fixtures under test/ or a dev-only file.
  • Fix the \${manifest.name} escape (or generate the JSON with jsonEncode, not a template string).
  • Relates to #1560 / #1562 (install path) and the Beta channel epic #1499 (live marketplace may ship to Beta first).
Lingua principale
Dart
Stelle
23
Fork
1
Merge medio
31m
PR unite (30g)
570

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di QueryaHub/Querya-Desktop

Tutte le issue di QueryaHub/Querya-Desktop

Issue simili

Altre issue su Dart

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.