Undo/Cancel Completion Key Handler
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 55/100
Direzione di ricerca
The issue points to Completion.cs and the TabCompleteNext call path; start by reading that entry point alongside CompleteImpl and the vi completion entry points mentioned. Done means Ctrl+e restores the original line and cursor after repeated forward or backward completion in the supported vi modes, while leaving ordinary editing unaffected.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Prerequisites
- Write a descriptive title.
Description of the new feature/enhancement
Like vim, it would be nice to be able to ctrl+e to cancel all the previous completions. If one gets three tabs into a completion cycle, it can be annoying to have to realize your search space is too wide and have to undo many times to get back to the initial text to be completed.
Proposed technical implementation details (optional)
Playing with the below naive implementation. Problems are tracking the "is completing" state and movement of the cursor during completions.
& {
$psrlTabState = [PSCustomObject]@{
OriginalLine = $null
OriginalCursor = 0
CompletedLine = $null
CompletedCursor = 0
}
$tabHandlerSb = {
param($key, $arg)
$line = $null
$cursor = 0
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
if (
$null -eq $psrlTabState.CompletedLine -or
$line -cne $psrlTabState.CompletedLine -or
$cursor -ne $psrlTabState.CompletedCursor
)
{
$psrlTabState.OriginalLine = $line
$psrlTabState.OriginalCursor = $cursor
}
[Microsoft.PowerShell.PSConsoleReadLine]::TabCompleteNext($key, $arg)
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
$psrlTabState.CompletedLine = $line
$psrlTabState.CompletedCursor = $cursor
}.GetNewClosure()
$viTabHandlerSb = {
param($key, $arg)
$line = $null
$cursor = 0
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
if (
$null -eq $psrlTabState.CompletedLine -or
$line -cne $psrlTabState.CompletedLine -or
$cursor -ne $psrlTabState.CompletedCursor
)
{
$psrlTabState.OriginalLine = $line
$psrlTabState.OriginalCursor = $cursor
}
[Microsoft.PowerShell.PSConsoleReadLine]::ViTabCompleteNext($key, $arg)
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
$psrlTabState.CompletedLine = $line
$psrlTabState.CompletedCursor = $cursor
}.GetNewClosure()
$prevTabHandlerSb = {
param($key, $arg)
$line = $null
$cursor = 0
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
if (
$null -eq $psrlTabState.CompletedLine -or
$line -cne $psrlTabState.CompletedLine -or
$cursor -ne $psrlTabState.CompletedCursor
)
{
$psrlTabState.OriginalLine = $line
$psrlTabState.OriginalCursor = $cursor
}
[Microsoft.PowerShell.PSConsoleReadLine]::TabCompletePrevious($key, $arg)
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
$psrlTabState.CompletedLine = $line
$psrlTabState.CompletedCursor = $cursor
}.GetNewClosure()
$viPrevTabHandlerSb = {
param($key, $arg)
$line = $null
$cursor = 0
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
if (
$null -eq $psrlTabState.CompletedLine -or
$line -cne $psrlTabState.CompletedLine -or
$cursor -ne $psrlTabState.CompletedCursor
)
{
$psrlTabState.OriginalLine = $line
$psrlTabState.OriginalCursor = $cursor
}
[Microsoft.PowerShell.PSConsoleReadLine]::ViTabCompletePrevious($key, $arg)
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
$psrlTabState.CompletedLine = $line
$psrlTabState.CompletedCursor = $cursor
}.GetNewClosure()
$cancelCompHandlerSb = {
$line = $null
$cursor = 0
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
if (
$null -ne $psrlTabState.CompletedLine -and
$line -ceq $psrlTabState.CompletedLine -and
$cursor -eq $psrlTabState.CompletedCursor
)
{
[Microsoft.PowerShell.PSConsoleReadLine]::Replace(
0,
$line.Length,
$psrlTabState.OriginalLine
)
[Microsoft.PowerShell.PSConsoleReadLine]::SetCursorPosition(
$psrlTabState.OriginalCursor
)
}
$psrlTabState.OriginalLine = $null
$psrlTabState.OriginalCursor = 0
$psrlTabState.CompletedLine = $null
$psrlTabState.CompletedCursor = 0
}.GetNewClosure()
Set-PSReadLineKeyHandler -Chord 'Tab' -ViMode 'Insert' -ScriptBlock $viTabHandlerSb -BriefDescription 'ViTabCompleteNextSaveState' -Description 'Match ViTabCompleteNext functionality and save state for CancelCompletion'
Set-PSReadLineKeyHandler -Chord 'Tab' -ViMode 'Command' -ScriptBlock $tabHandlerSb -BriefDescription 'TabCompleteNextSaveState' -Description 'Match TabCompleteNext functionality and save state for CancelCompletion'
Set-PSReadLineKeyHandler -Chord 'Shift+Tab' -ViMode 'Insert' -ScriptBlock $viPrevTabHandlerSb -BriefDescription 'ViTabCompletePreviousSaveState' -Description 'Match ViTabCompletePrevious functionality and save state for CancelCompletion'
Set-PSReadLineKeyHandler -Chord 'Shift+Tab' -ViMode 'Command' -ScriptBlock $prevTabHandlerSb -BriefDescription 'TabCompletePreviousSaveState' -Description 'Match TabCompletePrevious functionality and save state for CancelCompletion'
Set-PSReadLineKeyHandler -Chord 'Ctrl+e' -ViMode 'Insert' -ScriptBlock $cancelCompHandlerSb -BriefDescription 'CancelCompletion' -Description 'Revert and undo all of the previous completions. Relies on SaveState suffixed key handlers.'
}
EDIT 1 : Better code implementation handling vi mode. Apparently TabCompleteNext doesn't handle VI mode like Complete or MenuComplete.
EDIT 2: Curious why TabCompleteNext doesn't have the same call stack and call CompleteImpl.
EDIT 3: Updated the script with finalized version which properly takes in account the Vi related tab complete next. I'm using chezmoi template on [scriptblock] and they are all the same accept for the *TabComplete* method they call. Now maybe there is some way to handle it with the ConsoleKeyInfo passed in to reduce the duplication. I just solved with an embedded golang template.
- Lingua principale
- C#
- Stelle
- 4.4k
- Fork
- 341
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di PowerShell/PSReadLine
-
Needs-Triage :mag:
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
PowerShell/PSReadLine#5205 ·
-
Needs-Triage :mag:
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
PowerShell/PSReadLine#5195 ·
-
Needs-Triage :mag:
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
PowerShell/PSReadLine#5121 ·
-
Needs-Triage :mag:
Difficoltà 2/5 1-3 ore Idoneità per principianti 64/100
PowerShell/PSReadLine#5045 ·
-
Area-CommandHelp Issue-Enhancement
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 68/100
PowerShell/PSReadLine#3470 · 3 reazioni ·
Tutte le issue di PowerShell/PSReadLine
Issue simili
-
Documentation
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
cake-build/cake#5024 ·
-
Frontend status/draft TechnicalDebt
Difficoltà 2/5 1-2 giorni Idoneità per principianti 75/100
Altinn/altinn-auth#4143 ·
-
.NET Flaky Test Testing Tests
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
getsentry/sentry-dotnet#5617 · 1 commento ·
-
:watch: Not Triaged dotnet-fsharp/svc
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
-
Client customer-reported needs-team-attention question Service Attention WebPubSub
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
Azure/azure-sdk-for-net#63292 · 3 commenti · 1 reazione ·