Finish the cutover to source-generated schemas and publish missing version folders
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 35/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Tranquilla
- Stack tecnologico
- powershell, rust
- Ambito
- build-system, ci-cd, devtools
Direzione di ricerca
Inizia leggendo schemas/src e schemas/build.ps1, quindi esamina le implementazioni di DscRepoSchema in lib/dsc-lib ed esegui cargo xtask schema export. Confronta l'output generato con le cartelle schemas/ esistenti e con la copertura Pester proposta in dsc/tests. Il lavoro è completato quando gli schemi generati coprono i tipi dichiarati e le versioni rilasciate, evitano derive e convalidano i manifesti di esempio del repository.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary of the new feature / enhancement
As a configuration author or resource developer using the published DSC schemas,
I want the schemas to publish for every released version and stay in sync with the engine automatically,
So that editor validation and IntelliSense help me instead of contradicting DSC.
Currently the published schemas under schemas/ are built from hand-maintained YAML sources (schemas/src via schemas/build.ps1) that were last generated for v3.1.0, while the engine has moved on to 3.4.
The most visible symptom is that recognized $schema URIs don't resolve. The engine accepts every version through v3.2.3 as a valid $schema value, but no schema folder was ever published after v3.1.0, so a document pinned to a URI like this validates in DSC and 404s in the editor:
$schema: https://aka.ms/dsc/schemas/v3.2/bundled/config/document.json
The YAML sources have also drifted from the engine — fields, enum values, and whole subsystems added since v3.1.0 aren't represented, and in several cases the published schemas reject manifests this repository ships. Those content gaps will be filed as individual issues; this issue tracks the underlying problem that makes them inevitable.
That underlying problem is that the repository has two schema systems mid-migration. The YAML pipeline is what publishes, but every release requires manually editing schemas.config.yaml, re-running build.ps1 per version folder, and hand-updating the $schema URI enums in the sources — steps nothing enforces, which is how seven releases shipped without schemas. Meanwhile the source-based generator from #538/#1406 (DscRepoSchema + cargo xtask schema export) derives schemas directly from the engine's types — making drift structurally impossible — but is nearly complete rather than complete: it has never published anything, and no CI exercises either system.
Proposed technical implementation details (optional)
Finish the cutover to generated schemas in phases, each independently reviewable:
- Exporter correctness (#1672): fix the two silent path collisions (
AdaptedDscResourceManifest,DeleteWhatIfResult), export every type that derivesDscRepoSchema, fail on duplicate output paths, add--schema-version/--releasetargeting, and routedsc schemathrough the same machinery so the CLI and exporter agree. - Bundling and namespace parity: expand
should_bundleto match the 24 bundled schemas the YAML pipeline publishes today, and decide the disposition of each YAML-only schema (resource/stdout/*,resource/properties/*,metadata/Microsoft.DSC/*), with$refalias stubs in the floating version folders for moved paths. - Authoring parity: port the
title/description/VS Code keywords from the YAML sources onto the Rust types using the existingschema_i18n!pattern, with a comparison report gating the cutover so generated schemas don't regress the editor experience. - CI: commit
schemas/vNext, regenerate it in CI and fail on drift, and validate the repository's own example configurations and manifests against the generated schemas. - Backfill: publish the missing
v3.1.1–v3.2.3folders from each release tag's own sources so every recognized URI resolves. - Cutover: the next stable release publishes its folders via
cargo xtask schema export --release, after whichschemas/srcandschemas/build.ps1can be retired.
The CI checks (phase 4) fit naturally as a Pester test in dsc/tests, so they run in the existing ./build.ps1 -Test -PesterTestGroup dsc job as well as in a dedicated schemas workflow that invokes cargo xtask schema export first. Something like:
BeforeDiscovery {
# Every (folder_path, base_name) pair declared with #[dsc_repo_schema(...)]
$declarations = Get-ChildItem lib/dsc-lib/src -Recurse -Filter '*.rs' | ForEach-Object {
[regex]::Matches(
(Get-Content $_.FullName -Raw),
'(?s)base_name\s*=\s*"(?<base>[^"]+)"\s*,\s*folder_path\s*=\s*"(?<folder>[^"]+)"'
) | ForEach-Object {
@{ folder = $_.Groups['folder'].Value; base = $_.Groups['base'].Value }
}
}
}
Describe 'exported schemas' {
It 'exports <folder>/<base>.json' -TestCases $declarations {
Join-Path 'schemas/vNext' $folder "$base.json" | Should -Exist
}
It 'has no uncommitted drift' {
git diff --exit-code -- schemas/vNext
$LASTEXITCODE | Should -Be 0 -Because 'run `cargo xtask schema export` and commit the result'
}
}
Describe 'instance validation' {
It 'validates <name> against the generated manifest schema' -TestCases $manifests {
Test-Json -Path $path -SchemaFile 'schemas/vNext/bundled/resource/manifest.json' | Should -BeTrue
}
}
The first block also catches the "derives DscRepoSchema but was never exported" class of bug statically, and the instance validation is the regression proof for the drift issues: manifests in this repository that fail against the published v3.1.0 schemas today must pass against the generated ones.
- Lingua principale
- Rust
- Stelle
- 526
- Fork
- 76
- Merge medio
- 4g 22h
- PR unite (30g)
- 25
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di PowerShell/DSC
-
Issue-Enhancement Needs Triage
Difficoltà 3/5 1-2 giorni Idoneità per principianti 55/100
PowerShell/DSC#1731 ·
-
Issue-Enhancement Needs Triage
Difficoltà 5/5 Più di una settimana Idoneità per principianti 38/100
PowerShell/DSC#1729 ·
-
Issue-Bug Need-Review
Difficoltà 3/5 1-2 giorni Idoneità per principianti 55/100
PowerShell/DSC#1727 · 4 commenti ·
-
Issue-Enhancement
Difficoltà 4/5 3-5 giorni Idoneità per principianti 62/100
PowerShell/DSC#1722 · 3 commenti ·
-
Dev-UX Needs Triage
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
PowerShell/DSC#1694 ·
Tutte le issue di PowerShell/DSC
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
TheLarkInn/aipm#2413 ·
-
documentation
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
alexgorbatchev/simple-ptt#15 ·
-
tooling
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
todo:ticket
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
taikoxyz/taiko-mono#22168 · 1 commento ·