Audit runs can leave .posthog-audit-checks.json in the user's project
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Idoneità per principianti
- 75/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- typescript
Direzione di ricerca
Il file del registro di audit viene creato in src/lib/programs/audit/seed.ts e gestito in src/lib/programs/run-agent-legacy.ts. Esamina il blocco finally dove viene chiamato ledger.stop() e aggiungi un'eliminazione del file per programConfig.auditLedgerFile. Controlla anche src/agent/runner/harness/pi/security.ts per regolare l'ordine di registrazione per le rimozioni di file con ambito. Esegui il programma di audit localmente per verificare che il file venga ripulito e che non compaiano log fuorvianti 'bash denied'.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Problem
The wizard writes .posthog-audit-checks.json into the project root before the audit agent starts. No wizard code deletes it. The audit skills end with an instruction for the agent to run rm -f .posthog-audit-checks.json. The file is removed only if the agent runs that last step.
When the agent skips the step, the run still completes and the user keeps an untracked JSON file in their repo root, next to their own code. The next run does not break: the watcher ignores a leftover ledger and the seed replaces it. But the file is clutter, and a user can commit it by accident.
There is a second, smaller problem in the same path. On pi, a scoped rm of that file is logged as Denying bash command (not in allowlist) and captured as a bash denied event. Then the scoped-rm rule from #834 lets it run. The log and the telemetry say "denied". The command ran.
Evidence
Real-TUI sweep of the audit program on the wizard-workbench app audit/posthog-demo-3000. Harness pi (binding), sequence linear, model openai/gpt-5.6-sol.
- Refactor stack B2 head
d938a43b(#1307). The agent read step 6, uploaded the notebook, resolvedwrite-reportandupload-notebook, and published the handoff. It never ran therm. After exit,.posthog-audit-checks.json(3929 bytes) was still in the project root. - Release A top
200961f8(#1303). The agent ranrm -f .posthog-audit-checks.jsonand the file was removed. The wizard log shows the misleading pair:[pi] → bash {"command":"rm -f .posthog-audit-checks.json"} Denying bash command (not in allowlist): rm -f .posthog-audit-checks.json [pi] ← bash: {"content":[{"type":"text","text":"(no output)"}]}
The same prompt, harness and model gave both outcomes. The cleanup depends on the agent.
Code on main (d8486dc1):
src/lib/programs/audit/seed.ts:118-124:seedAuditLedgerwrites the ledger.src/lib/programs/audit/index.ts:26-29and:58call it before the agent starts. The wizard creates the file.src/lib/programs/run-agent-legacy.ts:81-95:runProgramAgentstarts the ledger watcher and stops it infinally. Nothing removes the file.src/lib/programs/audit/ledger-watcher.ts:32: "A ledger an earlier run left behind stays ignored until this run writes." The code already expects leftovers.src/lib/runners/run-wizard.ts:223: the task stream reads the checks from the session (getAuditChecks(session)), not from the file. Nothing reads the file after the run.src/agent/runner/harness/pi/index.ts:741-749: pi deletes.posthog-events.jsonhost-side after the run. There is no matching cleanup for the audit ledger.src/agent/runner/harness/pi/runtime-notes.ts:53: pi still tells the agent thatbashis only for install, build, typecheck, lint and format commands. #894 names this line as the reason agents skiprm. #1000 would update it.src/agent/runner/harness/pi/security.ts:372-385:evaluateToolCallcallswizardCanUseToolfirst and appliesisScopedFileRemovalafter.src/agent/agent-interface.ts:523-528:wizardCanUseToollogsDenying bash commandand capturesbash deniedbefore it returns the deny that pi then overrides.
Skill side, context-mill main:
context/skills/audit/description.md:49andcontext/skills/audit/references/6-report.md:284tell the agent to delete the ledger.- The same step is in the six
audit-*leaf skills, for examplecontext/skills/audit-events/references/4-report.md:21, and incontext/skills/events-audit/references/6-dashboard.md:270. - context-mill#306 (open) moves reports to
publish_handoffand keeps the agent-driven delete.
The refactor stack has the same behavior. On d938a43b, src/programs/program-file-watchers.ts:16-58 owns the ledger for the run, but stop() only stops the watcher (src/programs/run-program.ts:706-708).
Prior work. #833 added a host-side cleanupArtifacts seam for .posthog-events.json. It was closed because it worked around pi blocking rm, and #834 fixed that instead. This case is different. rm works here, and the agent did not run it. The wizard also seeds this file, so the program is the file's owner. #898 and #901 fixed the misleading deny log and telemetry. Both were closed without merging, and main still has the old order. #612 (open) raises the same class of leak for /tmp scratch files that skills name themselves, and leans toward a skill-side fix because the wizard does not know those names. That concern does not apply here: the program declares the name in auditLedgerFile, so the wizard can delete it without learning skill filenames. #894 (open) would make the agent more likely to run the rm, but cleanup would still depend on the agent.
Suggested fix
- Delete the ledger in the wizard after the agent run settles, on every exit path. On main, remove
path.join(session.installDir, programConfig.auditLedgerFile)withforce: trueafterledger.stop()in thefinallyofrunProgramAgent, and in theregisterCleanupcallback so aborts clean up too. On the stack, do it instartProgramFileWatchers().stop()or next to it in therun-program.tsfinally. This coversaudit,events-auditand the family leaves, because they all setauditLedgerFile. - In context-mill, remove the "delete
.posthog-audit-checks.json" step from the audit skills, or mark it optional, once the wizard deletes the file. Then the skill and the wizard do not both own the file. - In
evaluateToolCall, decide the scoped-rm rule before the deny is logged and captured. Keep thedisallowedToolscheck. Log an allow line for the command that runs, and do not capturebash deniedfor it. #898 has a small version of this change.
- Lingua principale
- TypeScript
- Stelle
- 204
- Fork
- 54
- Merge medio
- 1g 5h
- PR unite (30g)
- 51
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Nessuna guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di PostHog/wizard
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
PostHog/wizard#1460 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Self-driving setup: checkbox labels and Confirm button overlap wrapped description textForse di nuovo libera Una pull request per questa issue è stata chiusa senza essere unita. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
PostHog/wizard#986 · 4 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
Intro shows "(detected)" after a manual pick from the detection-failed pickerForse già presa @ShobhanKarthish l’ha presa 72 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
I maintainer di solito rispondono entro 1 giorno
-
wizard-pain
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di PostHog/wizard
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
I maintainer di solito rispondono entro 2 giorni
-
nip98: validateEvent skips the payload check for a string or bytes bodyForse di nuovo libera Una pull request per questa issue è stata chiusa senza essere unita. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
nbd-wtf/nostr-tools#599 ·
I maintainer di solito rispondono entro 1 giorno
-
[v1 UI] Report community modal stays open on success and shows unclear error toast on failureApertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
LemmyNet/lemmy-ui#4442 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
Zettlr/Zettlr#6664 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Microsoft Outlook add attachment reads the binary field from item 0Forse già presa @joshbarros l’ha presa oggi. Apertastatus:in-linear
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
n8n-io/n8n#44021 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno