Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

A dataset reform simulation's baseline loses inputs the reform neutralizes

Aperta
  • Qualcosa non va?
#632 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 3 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
backend

Direzione di ricerca

Run the reproduction script to confirm the reform baseline returns [0.0, 0.0] instead of [10.0, 20.0]. Read Simulation.__init__ and _bind_to_tax_benefit_system in simulations/simulation.py around lines 405-413, then Holder.set_input in holders/holder.py:460 to see where neutralized inputs are dropped. Compare with the situation-path fix in #613; the dataset path still needs to load the dataset under the baseline system. Done means the reform simulation returns defaults while reformed.baseline returns the dataset's original values.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Problem

When a simulation built from a dataset applies a reform that neutralizes an input variable, its baseline loses that input as well. The baseline then reads the variable's default, so reform-vs-baseline comparisons describe the wrong baseline.

Simulation.__init__ builds the reform simulation from the dataset under the reform's system. Holder.set_input ignores a value for a neutralized variable (holders/holder.py:460). The baseline is then get_branch("baseline"), rebound to the baseline system by _bind_to_tax_benefit_system (simulations/simulation.py:405-413 in 3.32.27). So the branch inherits holders that never received the column. The rebinding makes the variable un-neutralized again, but there is no data left to read.

#613 fixes the same gap for situations: it builds the baseline from the situation under the baseline system. It keeps the old binding when there is no situation (a dataset, or populations given), so the dataset path still has the bug.

Reproduction (core 3.32.27; master 037960cab has the same set_input and baseline code)

import warnings

import numpy as np
from policyengine_core.entities import build_entity
from policyengine_core.model_api import Variable, YEAR
from policyengine_core.simulations import Simulation
from policyengine_core.taxbenefitsystems import TaxBenefitSystem

Person = build_entity("person", "persons", "Person", is_person=True)


class person_id(Variable):
    value_type = int
    entity = Person
    definition_period = YEAR
    label = "Person ID"


class hours(Variable):
    value_type = float
    entity = Person
    definition_period = YEAR
    label = "Hours, an input"


class System(TaxBenefitSystem):
    def __init__(self, reform=None):
        super().__init__([Person])
        self.add_variables(person_id, hours)
        if reform is not None:
            self.apply_reform_set(reform)


class Sim(Simulation):
    default_tax_benefit_system = System
    default_tax_benefit_system_instance = System()


class Data:
    name = "repro"
    data_format = "arrays"
    time_period = "2024"
    file_path = None

    def load(self):
        return {"person_id": np.array([1, 2]), "hours": np.array([10.0, 20.0])}


class NeutralizeHours:
    def apply(self, system):
        system.neutralize_variable("hours")


with warnings.catch_warnings():
    warnings.simplefilter("ignore")
    reformed = Sim(dataset=Data(), reform=NeutralizeHours())
print("plain simulation:   ", Sim(dataset=Data()).calculate("hours", 2024).tolist())
print("reform:             ", reformed.calculate("hours", 2024).tolist())
print("reform's baseline:  ", reformed.baseline.calculate("hours", 2024).tolist())

Output:

plain simulation:    [10.0, 20.0]
reform:              [0.0, 0.0]
reform's baseline:   [0.0, 0.0]

The baseline should read [10.0, 20.0], as the plain simulation does.

Possible fix

Build a dataset reform simulation's baseline branch by loading the dataset under the baseline system, as #613 does for situations. Alternatively, keep the dataset's values for neutralized variables, without exposing them to the reform, so the baseline branch can read them.

Found while reviewing PolicyEngine/policyengine-us#10447. A reform that neutralizes unemployment_compensation_start_month makes both the reform and its baseline treat the column as unsupplied.

🤖 Generated with Claude Code

Lingua principale
Python
Stelle
22
Fork
30
Merge medio
4g 16h
PR unite (30g)
35

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di PolicyEngine/policyengine-core

Tutte le issue di PolicyEngine/policyengine-core

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.