"order" of Pokémon forms is shared between unrelated species

Inizia esaminando pokemon_forms.csv, la Pokémon Forms documentation e la pull request collegata #1532 per comprendere il comportamento attuale di order e i valori duplicati esistenti. Il lavoro è completato solo quando è stata concordata la sostituzione di order o id, ne è stato definito l’effetto sul modello dei dati e i record delle forme interessati sono stati aggiornati in modo coerente.

At present, the order column of the pokemon_forms.csv is mostly just an incrementing list that groups all forms of the same species together. This makes it very inconvenient to insert new forms for pre-existing Pokémon, as every subsequent entry needs to have its order incremented.

However, while the list at first appears to be an incrementing list (with a unique value per form), this is not actually the case (as I discovered in https://github.com/PokeAPI/pokeapi/pull/1532). The documentation does note

Multiple forms may have equal order, in which case they should fall back on sorting by name.

The first major group of non-unique entries is Alcremie. The Alcremie forms have distinct order values for each Cream, but each Cream shares the same order value across Sweets. So alcremie-vanilla-cream-berry-sweet is 1256 and alcremie-ruby-cream-berry-sweet is 1257, but alcremie-vanilla-cream-love-sweet is also 1256.

However, after Alcremie, there are a bunch of DLC Sword & Shield Pokémon, Hisui Pokémon, and Paldean Pokémon that share order values with Gigantamax Pokémon and forms introduced in Hisui and Paldea. Some examples:

Proposal

My proposal is that the order column do something similar to what Pokémon Champions does internally: Concatenate a National Pokédex number and a form ID to produce a unique identifier for a specific form of a Pokémon. For example, Venusaur (Pokédex #0003) would be form ID 00003000, while Mega Venusaur would be form ID 00003001, and Charmander (Pokédex #0004) would be form ID 0004000. (Since these are integers, the leading 0's would be stripped, but I've included them here to illustrate how the numeric identifiers are based on Pokédex numbers.)

This could even replace the existing id column of the pokemon_forms.csv table, and the order column could just be deprecated.