PointCloudLibrary/pcl

Can we have makeShared() for pcl::PolygonMesh?

Open

#2752 aperta il 30 dic 2018

Vedi su GitHub
 (6 commenti) (0 reazioni) (0 assegnatari)C++ (4506 fork)batch import
good first issuekind: todomodule: common

Metriche repository

Star
 (9023 star)
Metriche merge PR
 (Merge medio 8g 7h) (3 PR mergiate in 30 g)

Descrizione

Your Environment

  • Operating System and version: Ubuntu 18.04
  • Compiler: GCC 7
  • PCL Version: Latest

Context

I was experimenting with pcl::MeshSmoothingLaplacianVTK and then I realize there isn't a makeShared() function of pcl::PolygonMesh. For example, for the usual pcl::PointCloud<pcl::PointXYZ> we can do something like below

pcl::PointCloud<pcl::PointXYZ> cld;

pcl::VoxelGrid<pcl::PointXYZ> vox;
vox.setInputCloud(cld.makeShared());
vox.filter(cld);

but I can't do the below

pcl::PolygonMesh mesh;

pcl::MeshSmoothingLaplacianVTK vtk;

vtk.setInputMesh(mesh.makeShared());
vtk.process(mesh);

eventually I figured out if I want to keep my variables as object based and avoid mixing and matching with pointers, the below seems to work

pcl::PolygonMesh mesh;

pcl::MeshSmoothingLaplacianVTK vtk;

vtk.setInputMesh(boost::make_shared<pcl::PolygonMesh>(mesh));
vtk.process(mesh);

I am wondering is there a reason there isn't a makeShared() function for pcl::PolygonMesh? Or is it simply someone need to submit a PR to add that functionality?

Guida contributor