Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

security: narrow macOS sandbox file access and isolate command temp directories

Aperta
  • Qualcosa non va?
#96 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
30/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
macos, typescript
Ambito
desktop, security

Direzione di ricerca

Start with src/main/tools/sandbox.ts and the existing real Seatbelt tests and macOS CI leg; first trace how seatbeltProfile grants filesystem access and how command temp directories are configured. Run the native macOS tests and extend them to cover the listed access, alias, network, descendant, and cleanup cases. Done means the acceptance checks pass on a real Mac, with missing or broken Seatbelt execution treated as failure.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement platform: macos priority: medium security severity: medium

Observed policy

seatbeltProfile in src/main/tools/sandbox.ts starts with (deny default) but then grants (allow file-read*), denies reads beneath the current user's home, and reopens the project and selected toolchain directories.

Its writable set includes env.cwd, env.tmp, /tmp, /private/tmp, and all of /private/var/folders. Consequently, the filesystem policy is broader than a project plus a private command-temp directory:

  • OS-readable files outside the current user's home are generally readable, including other project/data locations.
  • Existing OS-writable files in shared temp trees are within the sandbox's permitted write scope, not just files created for this command.

These are findings from policy inspection, not a demonstrated macOS exploit. Ordinary filesystem permissions still apply. Do not describe this as a confirmed sandbox escape.

Proposed outcome

  • Replace blanket filesystem reads with explicit system/runtime/toolchain read grants, plus the project and that command's temporary directory.
  • Give each command a private temporary directory and point its temp environment variables there; do not grant entire shared temp trees merely to support temporary files.
  • Keep required special-device and runtime exceptions narrow and documented.
  • Resolve path aliases/symlinks consistently, including /var versus /private/var and /tmp versus /private/tmp.
  • Preserve no-network defaults, foreground/background behavior and fail-closed startup. Additional access should require explicit approval rather than silent widening.

Acceptance checks on a real Mac

  • Successfully launch a probe and demonstrate project/private-temp writes and required toolchain reads.
  • Deny reading a disposable OS-readable fixture outside the project/home grants and modifying a sibling fixture in shared temp storage; retain an unsandboxed control proving the host can perform those operations.
  • Cover symlink/path aliases, credential locations, network denial and background descendants.
  • Exercise representative build tools and private-temp cleanup on success, timeout and cancellation.
  • Keep native-backend CI requirements; missing or broken Seatbelt execution must not count as a passed isolation test.

Follow-up to #76. Existing real Seatbelt tests and the macOS CI leg should be extended, not replaced by another nominal coverage-only suite. Packaged-app signing/manual launch work remains separate (#22, #71).

Lingua principale
TypeScript
Stelle
2
Fork
2
Merge medio
6h 27m
PR unite (30g)
37

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di PierrunoYT/patch

Tutte le issue di PierrunoYT/patch

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.