OpenPanel.initialize blocks main thread / crashes on background thread due to WKWebView + DispatchSemaphore deadlock in getiOSUserAgent
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 48/100
Direzione di ricerca
Start with DeviceInfo.getiOSUserAgent and trace how OpenPanel.initialize obtains and uses the user agent. Verify the behavior when initialization is called on both the main and a background thread, then make completion or fallback handling non-blocking while preserving the expected user-agent value.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
OpenPanel.initialize is not safe to call from either the main thread or a background thread due to a deadlock in the internal getiOSUserAgent implementation. This makes it impossible to initialize the SDK without causing either a crash or a ~1 second UI freeze.
Root cause
Inside DeviceInfo.getiOSUserAgent():
let webView = WKWebView(frame: .zero) // (1) must be on main thread
var userAgent = ""
let semaphore = DispatchSemaphore(value: 0)
DispatchQueue.main.async { // (2) queued on main thread
webView.evaluateJavaScript("navigator.userAgent") { (result, error) in
if let agent = result as? String { userAgent = agent }
semaphore.signal()
}
}
_ = semaphore.wait(timeout: .now() + 1.0) // (3) blocks calling thread
This creates two mutually exclusive failure scenarios:
Scenario A — Called from main thread:
Step (1) is fine.
Step (3) blocks the main thread via semaphore.wait.
Step (2)'s main.async block is queued but can never execute because the main thread is blocked.
The semaphore always times out after 1 full second, freezing the UI every time.
Scenario B — Called from a background thread:
Step (1) crashes immediately with Main Thread Checker: UI API called on a background thread: -[WKWebView .cxx_construct].
Observed crash (background thread):
Main Thread Checker: UI API called on a background thread: -[WKWebView .cxx_construct]
Queue name: com.apple.root.utility-qos
#5 OpenPanel.DeviceInfo.getiOSUserAgent()
#6 OpenPanel.DeviceInfo.getUserAgent()
#7 OpenPanel.OpenPanel.initialize(options:)
Observed freeze (main thread): OpenPanel.initialize always blocks the calling thread for exactly 1 second (the semaphore timeout), regardless of device speed, because the JS evaluation can never signal the semaphore while the thread is waiting on it.
Expected behavior
OpenPanel.initialize should be safe to call from the main thread without blocking it. The user agent should be fetched asynchronously and either:
Cached lazily on first use after a non-blocking async fetch, or
Fetched during initialize without blocking (e.g. completion-based), or
Simply use getBasicUserAgent() as the default and upgrade to the WKWebView-based UA once it becomes available asynchronously.
Suggested fix:
private static func getiOSUserAgent(completion: @escaping (String) -> Void) {
DispatchQueue.main.async {
let webView = WKWebView(frame: .zero)
webView.evaluateJavaScript("navigator.userAgent") { result, _ in
let agent = (result as? String) ?? getBasicUserAgent()
completion(agent + " OpenPanel/\(OpenPanel.sdkVersion)")
}
}
}
- Lingua principale
- Swift
- Stelle
- 5
- Fork
- 8
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Preparare l'ambiente
Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di Openpanel-dev/swift-sdk
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 20/100
Tutte le issue di Openpanel-dev/swift-sdk
Issue simili
-
FilePath.extension setter crashes with non-ASCII charactersForse già presa @crleonard l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
apple/swift-system#404 ·
I maintainer di solito rispondono entro 1 giorno
-
#️⃣ REX and feebacks 🔍 triage 🧑💻 Developer eXperience 🧰 library
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
Orange-OpenSource/ouds-ios#1795 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
RodnaPamet/agrent-ios#172 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
bug iOS 🍎 ui/ux
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
MerginMaps/mobile#4744 ·
I maintainer di solito rispondono entro 1 giorno