Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

preinst: bare jq + exit 1 blocks upgrades and opkg orphan-cleanup strips nodogsplash+jq on abort

Aperta
  • Qualcosa non va?
#814 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@Amperstrand ci sta già lavorando.

Dal 12/10/2026.

  • #901 di @Amperstrand — aperta

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
50/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
go, shell
Ambito
infrastructure

Direzione di ricerca

Start with packaging/preinst and find the branch that runs jq to update install_time on upgrades, which is the exit 1 path. First confirm the finding still reproduces on current main, since the issue says it was not re-verified. Done means the preinst no longer aborts an upgrade over this cosmetic field, and the postinst or packaging behaviour for nodogsplash and jq is decided. An OpenWrt VM is needed to run the upgrade path.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Migrated from Amperstrand/tollgate-module-basic-go#93 as part of the fork retirement — OpenTollGate/tollgate-module-basic-go is the single source of truth; the fork issue carries the original discussion and any lab evidence. Retirement plan: #758.]

Found during QEMU v0.5.0→v0.6.0 upgrade emulation (PRTA campaign #113, bench in physical-router-test-automation@40d1b56 / scripts/upgrade-emulation/).

Summary

packaging/preinst hard-fails (exit 1) when it cannot update the cosmetic install_time field via bare jq — and when the upgrade aborts, opkg's orphan cleanup removes nodogsplash and jq (autoinstalled deps of the old package), leaving the captive portal broken after a "failed safe" upgrade.

Reproduction (OpenWrt 24.10.1 x86_64 VM, opkg 2024-10-16)

  1. Install v0.5.0 (deps auto-resolve: nodogsplash, jq, ...)
  2. Attempt opkg install tollgate-wrt_v0.6.0…ipk in a state where jq is absent at preinst time (in our run: a concurrent/duplicate opkg transaction's aborted cleanup had removed it):
Upgrading tollgate-wrt on root from v0.5.0 to v0.6.0-alpha2...
/tmp/opkg-XXXX/tollgate-wrt-YYYY/preinst: line 5: jq: not found
Error: Failed to update install_time using jq
Collected errors:
 * pkg_run_script: package "tollgate-wrt" preinst script returned status 1.
 * preinst_configure: Aborting installation of tollgate-wrt.
...
nodogsplash was autoinstalled and is now orphaned, removing.
jq was autoinstalled and is now orphaned, removing.
  1. Result: still v0.5.0, portal (nodogsplash) gone, jq gone.

Facts pinned by forensics

  • Maintainer-script env probe (repacked ipk with env-logging preinst): opkg passes the caller's env through; PATH=/usr/sbin:/usr/bin:/sbin:/bin, and with jq present it IS found — the abort requires jq to actually be missing at that moment (any failed earlier transaction's orphan cleanup produces exactly that state).
  • The initial install never hits the jq path (fresh /etc/tollgate/install.json is created by the echo ELSE-branch, no jq) — only upgrades with existing install.json run the jq branch.
  • With jq present, the identical artifact upgrades cleanly (verified end-to-end: config/wallet/identities sha-preserved, payments work).

Recommended fix (two independent layers)

  1. preinst should never exit 1 for an install_time cosmetic — warn and continue (exit 0).
  2. Don't rely on bare jq: use /usr/bin/jq absolute path, or replace with a BusyBox-only JSON write (the field is a single integer; sed/awk suffices), or drop preinst entirely and let the binary own install_time.

Optional hardening: postinst could opkg-flag have_installed nodogsplash jq (or list them in a metapackage) so aborted transactions can't orphan the portal.

Evidence

  • physical-router-test-automation/results/upgrade-emulation/ (local, not in git): install/upgrade logs, preinst env capture, sha snapshots across upgrade→rollback→upgrade.

Migrated 2026-10-09. Applicability to current upstream main (4614ac2, post-rc1) was not re-verified during migration — confirming whether the finding still reproduces upstream is this issue's first task.

Lingua principale
Go
Stelle
12
Fork
14
Merge medio
1g 5h
PR unite (30g)
232

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di OpenTollGate/tollgate-module-basic-go

Tutte le issue di OpenTollGate/tollgate-module-basic-go

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.