Welcome Wizard: “Skip setup” reads as “cancel”, and there’s no way to quit before OpenSAK starts

Aperta
  • Qualcosa non va?
#1,288 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
62/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
desktop

Direzione di ricerca

Start in gui/dialogs/welcome_wizard.py at _skip() and save_all(use_defaults=True), then the button setup, and in app.py where the first-run check runs after wizard.exec(). The goal is a Cancel/Exit button and X-close that quit without saving, plus renaming the Skip and Installation Folder labels, which means updating the wizard* and settings_install_dir_label keys in every language file. Done when Cancel and X both leave no completed flag so the wizard reappears on the next launch, and the labels are updated in all languages.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: i18n area: UI improvement

Problem

A Windows user (portable ZIP) wanted to stop partway through the Welcome Wizard. The only button that looked like a way out was Skip setup, so he clicked it. That doesn’t cancel anything. _skip() saves all the defaults (_save_all(use_defaults=True)), marks the wizard as completed, and OpenSAK starts. The wizard then never comes back on later launches, even after the user deleted the program folder and unzipped it again. The settings in %APPDATA%\opensak (hidden by default) still record it as completed.

Two other things made this more confusing:

“Installation Folder” doesn’t mean what users expect. The page holds opensak.json and opensak.log, not the program. A user who thinks they’re choosing where the program goes is surprised to find OpenSAK.exe still where they unzipped it. The same wording is used in Settings → Advanced (settings_install_dir_label).
Closing the window (X) behaves differently from Skip setup. Closing rejects the wizard without saving, so OpenSAK starts with the defaults and the wizard shows again next time. Users can’t tell these two outcomes apart.
Proposal
Rename “Skip setup” to something that says what it does, for example “Use default folders”, with a tooltip or one line of text: “OpenSAK will use the standard folders. You can change them later in Settings → Advanced → Run setup wizard again.”
Add a real Cancel / Exit button that closes the wizard and quits OpenSAK without saving anything. The wizard then shows again on the next launch. Closing with X should do the same, so the window close and the button behave alike.
Rename “Installation Folder” to “Settings Folder” (or “Settings and log folder”) in the wizard and in Settings → Advanced. The code can keep install_dir; only the user-facing text changes.
Optional: on the Backup Folder page (and the other folder pages), mention that a new folder can be created from the Browse dialog with its New folder button. Alternatively, accept a path that doesn’t exist yet and create it on Finish, as already happens for the install and database folders (mkdir(parents=True) in _save_all).
Notes
All language files need the changed/new keys (wizard_skip, wizard_install_dir_title, wizard_install_dir_subtitle, settings_install_dir_label, plus a new key for the Cancel button).
Relevant code: gui/dialogs/welcome_wizard.py (_skip, _save_all, button setup), app.py (first-run handling after wizard.exec()).

Lingua principale
Python
Stelle
37
Fork
17
Merge medio
21h 5m
PR unite (30g)
131

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di OpenSAK-Org/OpenSAK

Tutte le issue di OpenSAK-Org/OpenSAK

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.