database: PostgreSQL DSN breaks IPv6 hosts and Validate accepts out-of-range ports

Aperta
#336 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
67/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
go, mysql, postgresql
Ambito
database

Direzione di ricerca

Locate PostgresConfig.DSN(), PostgresConfig.Validate(), MySQLConfig.Validate(), and the existing MySQLConfig.DSN() implementation in the database package. Read those methods and their tests first; the issue gives the IPv6 and port cases to cover. Done means PostgreSQL DSNs parse for the listed host forms, both validators reject ports below 0 or above 65535 while accepting 0, and the database tests pass.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Type/Bug
Describe the Bug

PostgresConfig.DSN() builds an invalid URL when Host is an IPv6 address, and Validate() accepts any port.

  • IPv6 hosts: DSN() joins the host and port with fmt.Sprintf("%s:%d", c.Host, c.Port). For Host: "::1", Port: 5432 the URL host is ::1:5432, which pgx rejects ("too many colons in address"), so New fails. IPv4-mapped literals such as ::ffff:10.0.0.1 fail the same way. MySQLConfig.DSN() already uses net.JoinHostPort, so only PostgreSQL is affected.
  • Out-of-range ports: PostgresConfig.Validate() and MySQLConfig.Validate() don't check Port, so a negative port or one above 65535 passes validation and fails later, at connect time, with a driver error. A port of 0 (omitted) is documented as "use the driver default" and is fine.
To Reproduce
cfg := database.PostgresConfig{
    Host: "::1", Port: 5432, User: "postgres", Password: "secret",
    Name: "app", SSLMode: "disable",
}
fmt.Println(cfg.Validate()) // <nil>
_, err := pgconn.ParseConfig(cfg.DSN())
fmt.Println(err)
// cannot parse `postgres://postgres:xxxxx@::1:5432/app?sslmode=disable`: failed to parse as URL
// (failed to split host:port in '::1:5432', err: address ::1:5432: too many colons in address)

cfg.Host, cfg.Port = "localhost", 70000
fmt.Println(cfg.Validate()) // <nil>
Expected Behavior
  • DSN() brackets IPv6 hosts, e.g. postgres://...@[::1]:5432/app, by using net.JoinHostPort as MySQLConfig.DSN() does. A host with no port that is an IPv6 literal is bracketed too ([::1]).
  • Validate() for PostgreSQL and MySQL rejects ports below 0 or above 65535. 0 keeps meaning "driver default".
  • A test parses DSN() with pgconn.ParseConfig for a hostname, IPv4, IPv6, an IPv4-mapped IPv6 address, and an already-bracketed [::1], with and without a port.
Screenshots

N/A

Version

database/v0.3.0

Environment Details (with versions)

Go 1.26, pgx v5, PostgreSQL 16

Additional Context

Found while moving the OpenNDX Portal Backend onto this package (openndx/openndx-core#688). The PB's old hand-built keyword DSN accepted host=::1, so this is a small regression for OpenNDX deployments that use an IPv6 database address. OpenNDX will bump the dependency once a fix is released, rather than work around it in each service.

Lingua principale
Go
Stelle
6
Fork
8
Merge medio
21h 36m
PR unite (30g)
42

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di OpenNSW/core

Tutte le issue di OpenNSW/core

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.