Allow overrides for std::terminate

Aperta
#270 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
70/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
cpp
Ambito
embedded-iot

Direzione di ricerca

Start in include/cetl/cetl.hpp and copy the existing CETL_DEBUG_ASSERT override pattern, then replace the std::terminate() calls in the five listed headers (optional.hpp line 761, variant.hpp line 227, string_view.hpp 137/244/261, unbounded_variant.hpp 70, pmr/function.hpp 78) inside their !defined(__cpp_exceptions) branches with CETL_TERMINATE(). Read CETL_DEBUG_ASSERT and any docs that describe it to match wording, and drop the now-unneeded <exception> includes from headers that only pulled it in for std::terminate. Done looks like: defining CETL_TERMINATE() to a trap before inclusion makes the library build with -fno-exceptions on a target without libsupc++, and the default still resolves to std::terminate().

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

accepted

With -fno-exceptions, CETL's bad-access paths call std::terminate(). On targets that link no C++ runtime library (no libsupc++; for example NuttX-based flight controllers), std::terminate does not exist, so any code that can reach these paths fails to link. Please provide a way for the user to supply a platform-specific termination routine that CETL calls instead of std::terminate() when exceptions are disabled.

Where (main @ bf1e5f3)

File Line Path
include/cetl/pf17/optional.hpp 761 ensure_engaged() (value())
include/cetl/pf17/variant.hpp 227 bad_access_unless() (get, visit)
include/cetl/pf17/string_view.hpp 137, 244, 261 out-of-range access
include/cetl/unbounded_variant.hpp 70 bad access
include/cetl/pmr/function.hpp 78 bad call

Proposal

A single overridable macro in cetl/cetl.hpp, following the existing CETL_DEBUG_ASSERT pattern:

/// @def CETL_TERMINATE
/// Called instead of throwing when exceptions are disabled. Must not return.
/// Define it before including any CETL header to route to a platform handler,
/// e.g. `#define CETL_TERMINATE() ::abort()` or a board-specific panic.
#ifndef CETL_TERMINATE
#    include <exception>
#    define CETL_TERMINATE() std::terminate()
#endif

All of the sites above would call CETL_TERMINATE() in their !defined(__cpp_exceptions) branches. That also lets the headers include <exception> only when the default is used. Several currently include it unconditionally "for std::terminate", which matters for builds that avoid C++ runtime headers.

Notes:

  • A macro (rather than a weak function) works for header-only use and avoids defining any symbol in namespace std.
  • Documenting that the handler must be [[noreturn]] and must not throw would let CETL keep its noexcept guarantees.
  • The upcoming expected polyfill's bad-access path (value() on an error) would naturally use the same hook.
  • A CI configuration that defines CETL_TERMINATE() as __builtin_trap() and checks that objects reference no std::terminate would catch regressions.
Lingua principale
C++
Stelle
18
Fork
4
Merge medio
7g 16h
PR unite (30g)
7

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di OpenCyphal/CETL

Tutte le issue di OpenCyphal/CETL

Issue simili

Altre issue su C++

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.