Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Require authenticated pairing before security-sensitive commands

Aperta
#74 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
rust

Direzione di ricerca

Start by reading docs/ble.md and checking the pairing and command handling entry points in the firmware, then investigate what trouble-host supports for authenticated pairing. The issue leaves the sensitive command list, pairing method, and existing bond behavior open, so those decisions need to be resolved with the related app and contracts work. Done means Just Works bonds cannot run sensitive commands and the chosen method is documented in docs/ble.md.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

Part of the prerequisites for real commands (tracking issue to follow). Related: #54, #9, mobile-app#25, contracts#8.

Problem

BLE bonding is Just Works, which has no protection against a stranger. While a pairing window is open (60 s with a button, or the first-setup window on a buttonless board), any phone in range can bond. #46 and #53 shrank the window, but they don't authenticate the phone. A bonded phone can later send any BLE command, including ones that unlock the car or open the trunk.

That is acceptable for harmless commands such as flashing the lights or climate control. It is not for door unlock, trunk or frunk.

Proposal

  • Classify commands as security-sensitive somewhere both sides read (a proto option or meta.toml; this overlaps with the delivery kind in contracts#7 and availability in contracts#13). This is a contracts change.
  • The firmware rejects security-sensitive commands unless the phone's bond was made with MITM protection (LE Secure Connections with passkey entry, numeric comparison or out-of-band data).
  • The WiCAN has no display or buttons, so the options are limited. Candidates: a passkey provisioned at setup and shown to the owner; out-of-band data carried in a QR code scanned by the app; or confirming a new phone with a pattern on the LED. The same applies to the way the window is reopened in #54, so decide them together.
  • Check what trouble-host supports before choosing.

Open questions

  • Which commands count as security-sensitive?
  • What happens to phones already bonded with Just Works (re-pair, or limited to non-sensitive commands)?
  • Does the app need a state for "paired, but not authenticated"?

Done when

A bond made with Just Works can't run security-sensitive commands, the chosen pairing method is documented in docs/ble.md, and a stranger who bonds during a window can't unlock the car.

Lingua principale
Rust
Stelle
1
Fork
0
Merge medio
14h 32m
PR unite (30g)
21

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

  • Nessun Dockerfile né file Docker Compose
  • Nessun modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di OpenCarControls/firmware

Tutte le issue di OpenCarControls/firmware

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.