`GetElementProperties` `Feature::type` leaves out the type a feature gets by subsetting when it also has its own typing

Aperta
#2,198 2 commenti 1 reazione 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@devin-ai-integration ci sta già lavorando.

Dal 15/11/2026.

  • #2263 di @devin-ai-integration — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
1-2 giorni
Idoneità per principianti
42/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
go, python
Ambito
backend

Direzione di ricerca

Start by running the SysML snippet in the issue through the Python client and comparing element_properties("P::Owner::pBoth", "type") with type_facts.types, then check the A40-040..042 cases in test-suite/data/models/A40.sysml. Find where the GetElementProperties type read stops at the feature's own typing and skips the types inherited through subsetting, and find the Symbol API code that already includes them. Done when type returns [P::V, P::T] for pBoth and the A40 types cases pass in the Go and Python property suites.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

This issue was written with AI help. The reproduction was run against the version below.

What happened

Since #2040 (#2007), the Symbol API's type_facts.types gives a feature's derived Feature::type, including the types it gets through subsetting. #2021's closing comment says it equals element_properties(el, "type"). For a feature that has both its own typing and a subsetting, the two answers differ:

package P {
    part def T;
    part def V;
    part def Owner {
        part q : T;
        part pBoth : V :> q;    // typed by V, subsets q : T
    }
}
m = opensysml.loads(SRC)                                         # no diagnostics
[t.id for t in m.get("P::Owner::pBoth").type_facts.types]        # ['P::V', 'P::T']
m.element_properties("P::Owner::pBoth", "type")                  # ['P::V']
Read P::Owner::pBoth
Symbol API type_facts.types P::V, P::T
GetElementProperties type P::V
Pilot Feature::type P::V, P::T

ownedTyping and ownedSubsetting each list their one relationship. A feature that only subsets (part pSub :> q;) answers P::T through both reads, so the gap seems to be the combination of the two.

Expected

type is [P::V, P::T]: KerML §8.3.3.3 Feature::type includes the types of the features it subsets. That is the answer of the Symbol API, the Pilot (0.64.0-SNAPSHOT, commit 378a8700c) and sysml-toolkit.

Version

OpenSysML develop at a159469093, bin/sysml-grpc from make build-grpc, Python client from client/python of the same commit.

Found by

The test suite at https://github.com/hideo67/sysmlv2-tests, matrix A40 (test-suite/data/matrices/A40.md, model test-suite/data/models/A40.sysml). pBoth's types fails on the def, through a typing usage and through a usage of a specializing def (A40-040..042), in opensysml-py-props and opensysml-go-props. The six Symbol API suites pass these cases.

Lingua principale
Go
Stelle
59
Fork
20
Merge medio
10h 23m
PR unite (30g)
897

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Open-MBEE/OpenSysML

Tutte le issue di Open-MBEE/OpenSysML

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.