fix(webhooks): Ignore the local-webhook escape hatch on mainnet and read it through one helper

Aperta
#656 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
78/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust

Direzione di ricerca

Start with the two environment variable reads in crates/webhooks/src/lib.rs and the startup checks and tests in bin/server/src/mainnet_guard.rs. Trace how the server determines whether it is on mainnet, then read the related documentation in docs/environment-variables.md and docs/threat-model.md. Done means one helper serves both reads, startup rejects the override on mainnet with a test, and both docs explain the development and tests only restriction.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area/integration bug good first issue help wanted

Description

OCTO_ALLOW_LOCAL_WEBHOOKS=1 disables the SSRF guard entirely and is read in two places in crates/webhooks/src/lib.rs (around lines 398 and 482). Nothing stops it from being set in production, and it is not in docs/environment-variables.md.

Requirements and context

  • Where: crates/webhooks/src/lib.rs, bin/server/src/mainnet_guard.rs, docs/environment-variables.md
  • Security: This variable turns off SSRF protection; on mainnet it must be impossible to enable by accident.
  • Testing: just fmt-check, just lint and just test must pass; add or update tests for the change.
  • Documentation: Document in docs/environment-variables.md and docs/threat-model.md.

Suggested execution

  • Comment on this issue to claim it, then fork the repository and branch from main.
  • Branch name: git checkout -b fix/webhooks-allow-local-mainnet

Implement changes

  • Add one allow_local_webhooks() helper and use it at both read sites.
  • Refuse to start on mainnet when the variable is set (add a message to mainnet_guard.rs).
  • Document the variable as 'development and tests only'.

Test and commit

  • Add a mainnet_guard test: variable set + mainnet = configuration error.
  • Run just fmt, just lint and just test locally before pushing (see CONTRIBUTING.md).
  • Commit with a conventional message and keep the change small and focused.

Example commit message

fix(webhooks): forbid local webhook override on mainnet

Guidelines

  • Open the PR against main and link it with Closes #<this issue>.
  • Keep the diff focused on this issue; no unrelated refactors or formatting churn.
  • One line per comment, no bloated code; follow patterns already used in the crate.
  • Never commit secrets, .env files or real keys; use public test vectors only.
  • CI (fmt, clippy -D warnings, tests) must be green before requesting review.
  • Ask in the issue thread if anything is unclear before starting.
Lingua principale
Rust
Stelle
0
Fork
91
Merge medio
5h 23m
PR unite (30g)
4

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Octo-Protocol-org/Octo-Protocol

Tutte le issue di Octo-Protocol-org/Octo-Protocol

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.