chore: fix TypeScript code quality violations from May 2026 audit
I maintainer di solito rispondono entro 2 giorni
Una pull request collegata è già stata integrata.
- #1230 di @prx-my — integrata
Valutazione
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Idoneità per principianti
- 84/100
- Tipo di issue
- Refactoring
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- typescript
Direzione di ricerca
Scegli un punto e commenta l’issue prima di iniziare. Leggi il file indicato e le costanti o i messaggi esistenti nelle vicinanze, mantieni le grafie e l’ambito specificati, quindi esegui npm test e npm run build; completato significa che il refactoring selezionato è completo senza combinare i punti.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Small, self-contained refactors from a code-quality audit. Each bullet below is its own task and its own PR - please do not try to do them all in one. Comment on the issue saying which one you are taking so others can see, though the first working PR is the one that lands.
Re-verified against main on 2026-09-16, so the counts and paths below are current.
1. Extract the CLI flag literals in src/cli/args.ts
39 distinct flag strings ("--json", "--all", "--offline" and so on) appear as inline literals, 55 occurrences in total. Extract them into named constants so a typo becomes a compile error rather than a silently unrecognised flag. src/constants.ts already holds this kind of thing (DEFAULT_BATCH_SIZE, CACHE_TTL_MS) and is a reasonable home, or a dedicated src/cli/flags.ts if that reads better.
Good first issue. Mechanical, but please keep the flag spellings byte-identical - the tests and the docs both depend on them.
2. Extract the install command in src/utils/update-check.ts
src/utils/update-check.ts:98 has npm install -g cve-lite-cli inline. The registry URL right above it is already a named constant (NPM_REGISTRY_URL), so this is following an established pattern in the same file.
Good first issue, genuinely a few lines.
3. De-duplicate the flag-conflict errors in src/cli/validate.ts
Seven near-identical --X cannot be used with --Y messages. Extract a helper that takes the two flag names and builds the message, so the wording stays consistent when the eighth one is added.
4. Add braces to the remaining single-line if statements
Corrected 2026-09-27: ten in src/cli/args.ts and one in src/index.ts:131, so eleven in total. This previously said eight and one. For example src/cli/args.ts:74:
if (!val) throw new Error("--ca-cert requires a path argument");
Note this was previously filed as #1089 and closed as not-planned, so it is genuinely still open. There is no linter enforcing it yet; adding ESLint with curly is tracked separately as #1091, and that will supersede this task if it lands first.
Not in scope
scanPackages in src/scanner.ts is 1122 lines and well past our 60-line guideline, but it is core scanner internals and is being handled in-house. Please do not refactor it as part of this issue.
Already fixed, please do not re-report
The original May 2026 audit listed several items that have since been resolved. Leaving them here so nobody spends time re-finding them:
- Nested ternary in
src/output/formatters.ts- now an else-if chain batchSize/searchDepth- nowDEFAULT_BATCH_SIZE/DEFAULT_SEARCH_DEPTHinsrc/constants.ts- Cache TTL - now
CACHE_TTL_MS - The npm registry URL - now
NPM_REGISTRY_URL - The
src/index.tsline references from the old audit are stale; that file was reduced from 973 lines to 191 in #1129, and the advisory-DB warnings it mentioned now live insrc/scan/single-scan.ts
Before you open a PR
Run npm test and npm run build. Keep each PR to one bullet above.
- Lingua principale
- TypeScript
- Stelle
- 801
- Fork
- 204
- Merge medio
- 3g 11h
- PR unite (30g)
- 135
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di OWASP/cve-lite-cli
-
docs(website): add a GitLab CI/CD button next to the GitHub Action button on the homepageForse già presa @shryssssss-maker l’ha presa oggi. Apertadocumentation enhancement first-timers-only good first issue
Difficoltà 1/5 1-3 ore Idoneità per principianti 88/100
OWASP/cve-lite-cli#1739 · 2 commenti ·
I maintainer di solito rispondono entro 2 giorni
-
[Bug] fix(remediation): parent upgrade rejected when child range is bumped past exact fix versionForse già presa @coder-Yash886 l’ha presa oggi. Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
OWASP/cve-lite-cli#1720 · 1 commento ·
I maintainer di solito rispondono entro 2 giorni
-
fix: pnpm fix commands for workspace-root dependencies omit -wForse già presa @sarankumar1325 l’ha presa 10 giorni fa. Apertabug help wanted
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
OWASP/cve-lite-cli#1582 · 1 commento ·
I maintainer di solito rispondono entro 2 giorni
-
CVE Lite CLI — Public Adoption TrackerForse di nuovo libera @Darshan3690 l’ha presa 24 giorni fa e non c’è nessuna pull request aperta. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
OWASP/cve-lite-cli#1396 · 2 commenti ·
I maintainer di solito rispondono entro 2 giorni
-
bug: chain-upgrade fixes always warn that another path may need a separate upgradeForse già presa @Medhansh-741 l’ha presa oggi. Apertabug help wanted
OWASP/cve-lite-cli#1736 · 8 commenti · 1 assegnatario ·
I maintainer di solito rispondono entro 2 giorni
Tutte le issue di OWASP/cve-lite-cli
Issue simili
-
awaiting-final-review request-icon
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 70/100
homebridge/plugins#1376 · 1 commento ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
mindfold-ai/Trellis#672 ·
-
p1 state:active track
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
StellarCanary/ProtocolCanary-Action#698 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
pear-devs/pear-desktop#4839 ·
I maintainer di solito rispondono entro 1 giorno