[Bug]: `nvidia-container-cli list` default listing depends on argv count (`--imex-channel 0` vs `--imex-channel=0`, `--no-persistenced` prints nothing)

Aperta Adatta ai principianti
#406 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
86/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
c
Ambito
cli

Direzione di ricerca

Leggi src/cli/list.c, in particolare list_parser() in corrispondenza di ARGP_KEY_END, e segui come le opzioni di selezione analizzate impostano il contesto dell’elenco. Riproduci con la CLI le forme di argv e i casi di opt-out; l’issue dice che è stato usato un backend stub. Il lavoro è completato quando le forme delle opzioni producono un output equivalente, i flag di opt-out mantengono l’elenco predefinito escludendo i relativi file e le opzioni di selezione esplicite conservano il comportamento attuale.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

needs-triage

Motivation

I was checking which files nvidia-container-cli list reports when IMEX channels or the new opt-out flags are used, and the output changed depending on how I spelled the same option.

  • I would like to work on this issue.

Describe the bug

list prints everything (device nodes, binaries, libraries, IPCs, firmware) when it is called without options. When --imex-channel was added, the IMEX-only case was meant to keep that default listing and add the channel nodes on top. The check in list_parser() (src/cli/list.c, ARGP_KEY_END) counts argv entries instead of looking at which options were given:

if (state->argc == 1 || (state->argc == 2 && ctx->imex_channels != NULL)) {

argp accepts both --imex-channel=0 (one argv entry) and --imex-channel 0 (two argv entries), so the result depends on the spelling:

  • list --imex-channel=0 prints the full listing plus /dev/nvidia-caps-imex-channels/channel0.
  • list --imex-channel 0 prints only /dev/nvidia-caps-imex-channels/channel0.
  • list --imex-channel=0 --imex-channel=1 prints only the two channel nodes, while list --imex-channel=0,1 prints everything.

The same check also affects the opt-out flags added in v1.16.2. --no-persistenced, --no-fabricmanager and --no-gsp-firmware only change what the driver lookup returns; they do not select anything to list. But each one makes argc == 2, so list --no-persistenced (or --no-gsp-firmware, or --no-fabricmanager) prints nothing and exits 0. The ctx->list_firmwares = false; in the --no-gsp-firmware case suggests the flag was expected to remove firmware from the default listing, not to empty it.

The IMEX gate has been there since v1.15.0, the opt-out flags since v1.16.2, and both are still on current main (c7727e5).

To Reproduce

The difference is in argument parsing only, so it shows on any host. The output below is from the current main CLI front-end built against a stub backend that reports one GPU, one binary, one library, the persistenced socket and one GSP firmware file:

$ nvidia-container-cli list --imex-channel=0
/dev/nvidiactl
/dev/nvidia0
/dev/nvidia-caps-imex-channels/channel0
/usr/bin/nvidia-smi
/usr/lib/libcuda.so.580.0.0
/run/nvidia-persistenced/socket
/lib/firmware/nvidia/580.0.0/gsp_ga10x.bin

$ nvidia-container-cli list --imex-channel 0
/dev/nvidia-caps-imex-channels/channel0

$ nvidia-container-cli list --no-persistenced
$ echo $?
0

$ nvidia-container-cli list --no-gsp-firmware
$ nvidia-container-cli list --no-fabricmanager

On a real host the first command prints the full driver file list; the second one still prints only the channel node.

Expected behavior

  • --imex-channel 0 and --imex-channel=0 give the same output, and repeating --imex-channel behaves like a comma-separated list.
  • list --no-persistenced prints the default listing without the persistenced socket; list --no-gsp-firmware prints it without the firmware files; list --no-fabricmanager prints it without the fabricmanager socket.
  • Options that select what to list (--device, --libraries, --binaries, --ipcs, --firmwares, --compat32, --mig-config, --mig-monitor) keep their current behavior: only the selected parts are printed.

Proposed fix

In ARGP_KEY_END, decide whether to apply the default listing from the parsed context instead of from state->argc: apply it when none of the selecting options above was given. --imex-channel and the --no-* flags then only modify the default listing, however they are spelled. The ctx->list_firmwares = false; line in the --no-gsp-firmware case is dropped: firmware lookup is already skipped through the driver option, and keeping the line would make list -f --no-gsp-firmware fall back to the full listing. The change is about 7 lines in src/cli/list.c and does not touch configure or the library.

I checked the change against these cases: list, list --libraries, list --device=0, list -f --no-gsp-firmware, list --compat32 and list --imex-channel=0 print exactly what they print today. list --imex-channel 0, repeated --imex-channel, and the three --no-* flags behave as described above. There is no C test suite in the repository, so I used a small out-of-tree script that runs the CLI against a stub backend; I can share it if that helps.

Environment (please provide the following information):

  • Version: main at c7727e5 (same code in v1.16.2 through v1.20.2)
  • OS / Distribution: Ubuntu 24.04 (aarch64)
  • Kernel Version: n/a (argument parsing only)
  • Container Runtime Version: n/a (nvidia-container-cli list called directly)

This change was drafted with Claude Code (claude-opus-5-5); the test results above are from the runs described.

Lingua principale
C
Stelle
1.1k
Fork
278
Merge medio
3g 7h
PR unite (30g)
2

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di NVIDIA/libnvidia-container

Tutte le issue di NVIDIA/libnvidia-container

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.