Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

refactor(upgrade): full Effect-native rewrite of the upgrade train

Aperta
  • Qualcosa non va?
#561 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
backend, devtools, testing

Direzione di ricerca

Start by locating upgradeTemplate and the syncTemplate release scoped path, then read the PlatformManifestService and ResolutionSessionService seams and the orchestrator's Effect.timeoutOrElse patterns. Run the targeted upgrade and CLI error suites plus pnpm run lint:effect; done means the paths use Effect with typed errors and service fakes, all checks pass, and the platform upgrade e2e confirms unchanged behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

Second half of the seam-pattern decision (the PlatformManifestService seam lands first): rewrite the upgrade train itself as Effect-native pipelines.

PR-level context: PlatformManifestService (the seam) wraps the platform-release-manifest cluster while the core stays plain async functions — the repo's "module is the implementation, the tag is the seam" shape (FastKVRegistryService, DeployTrainService precedents). This ticket rewrites the orchestration layer.

Scope

  • upgradeTemplate phases → Effect.gen pipelines: read-source / diff / preflight / package-apply / re-exec boundary / migration phases become effects with typed errors (a discriminated UpgradePhaseError replacing string-error UpgradeResult shapes where callers need them).
  • Typed error channel — PublishTrainError-style: handlers map failures to the wire shape mechanically instead of string matching.
  • Effect-lint parity — the cluster passes pnpm run lint:effect (floating effects, tag Self mismatches) under the type-aware oxlint preset.
  • Service-in-context throughout — upgradeTemplate consumes PlatformManifestService + ResolutionSessionService via yield* instead of direct plain-function imports.
  • Timeouts / interruption — the spawn-heavy phases (pnpm install, bos types gen, the re-exec boundary) get fiber-based timeouts instead of ad-hoc exit-code checks, matching the orchestrator's Effect.timeoutOrElse patterns.

Non-goals

  • No behavior change: the upgrade plot, pin semantics, drift alarms, and output shapes stay byte-identical (the platform-upgrade e2e is the guard).
  • Plain function exports stay as the pure core — a rewrite of the orchestration layer, not a deletion of the seams.

Acceptance

  • upgradeTemplate (and syncTemplate's release-scoped path) are Effect-native with typed errors.
  • Targeted suites (upgrade-migration, upgrade-template-sync-gating, upgrade-catalog-drift, cli-error-format) pass with service fakes, no vi.mock on the scaffold modules.
  • pnpm run lint:effect reports zero findings for the cluster.
Lingua principale
TypeScript
Stelle
5
Fork
3
Merge medio
9h 50m
PR unite (30g)
146

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di NEARBuilders/everything-dev

Tutte le issue di NEARBuilders/everything-dev

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.