[Regression on closed #570 / #318] Still no initial-schema migration — migration:run on a fresh database fails on the first ALTER TABLE

Aperta
  • Qualcosa non va?
#736 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
postgresql, typescript
Ambito
backend, database

Direzione di ricerca

Read src/database/data-source.ts:22 and inspect all migrations in src/database/migrations/, especially the earliest migration at 1784272650000-EscrowFkIntegrityAndSponsorId.ts:32. Reproduce the failure with npm run migration:run against an empty PostgreSQL database, then establish a baseline that creates the current schema and works with existing deployments. Done means migrations succeed from an empty database and a required CI job verifies that path.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Location — src/database/migrations/ (the whole directory), entry point src/database/data-source.ts:22. The earliest migration is 1784272650000-EscrowFkIntegrityAndSponsorId.ts:32.

Problem — The missing initial-schema migration closed as #318 and re-filed and closed as #570 is still missing on the default branch. Of the 15 migration files, exactly one contains a CREATE TABLE (1784304511000-CreateIdempotencyKeys.ts, for idempotency_keys). Every other migration is an ALTER TABLE / CREATE INDEX / ADD CONSTRAINT against tables that no migration ever creates: escrows, bounties, payments, issues, milestones, maintenance_pools, repositories, teams, team_member_splits, reputation_snapshots, users, github_accounts, webhook_events.

The first migration to run begins with:

await queryRunner.query(
  `ALTER TABLE "escrows" ADD COLUMN IF NOT EXISTS "sponsorId" varchar`,
);

Against an empty database this aborts with ERROR: relation "escrows" does not exist. (ADD COLUMN IF NOT EXISTS guards the column, not the table.) The schema therefore still only ever comes into existence through synchronize, which data-source.ts:25 correctly sets to false for the CLI — so the migration path and the only working schema-creation path are disjoint.

Why it matters — There is no way to stand up this application from the repository. A new contributor, a fresh CI database, a staging rebuild, or a production deploy all fail at the first migration. The practical workaround is to boot the app once with synchronize: true and then run migrations, which means the deployed schema is whatever the entity decorators happened to produce at that moment, with no reviewable record — the exact situation migrations were introduced (#14, #27) to eliminate. It also makes entity/migration drift undetectable: there is no baseline to diff against.

Reproduction / failure path

  1. createdb mergefi_fresh
  2. DATABASE_URL=postgresql://postgres:postgres@localhost:5432/mergefi_fresh npm run migration:run
  3. Fails immediately: QueryFailedError: relation "escrows" does not exist.

Suggested fix

  • Generate a baseline migration that creates the full current schema and number it before 1784272650000: boot a scratch database with synchronize: true against the current entities list, then run npm run migration:generate -- src/database/migrations/InitialSchema from an empty database and renumber the output to a timestamp lower than 1784272650000.
  • Make it idempotent for already-deployed environments (CREATE TABLE IF NOT EXISTS / CREATE TYPE ... IF NOT EXISTS guards), or document that existing databases must have the row inserted into migrations manually so the baseline is recorded as applied without re-running.
  • Add the CI step that #320/#572 asked for and wire it to a genuinely empty Postgres service container: migration:run on a fresh database must be a required job. Without it this will regress a fourth time — a migration suite that is never run from zero cannot be known to work.
Lingua principale
TypeScript
Stelle
2
Fork
90
Merge medio
31m
PR unite (30g)
20

Preparare l'ambiente

  • Include un Dockerfile o un file Docker Compose
  • Nessun modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di MergeFi/backend

Tutte le issue di MergeFi/backend

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.