Models are browsed by source, not one list with Source and Capability filters
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 45/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- react, typescript
- Ambito
- documentation, frontend
Direzione di ricerca
Read docs/proposals/model-catalog.md first, especially the Screen section and step 6; then inspect the named Add model and per-source group components under surfsense_local/frontend/src/features/models/. Start by writing a failing filter-behavior test, using the listed settings and download-model tests as guides. Done means the scoped part of the proposed unified list and filters is covered, with relevant docs updated; run pnpm test and python scripts/check_docs.py.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
The gap
docs/architecture/local-models/catalog.md lists this under Known gaps:
Browsing is still split by source, a catalog on the Add model page and one group per server, not the one list with Source and Capability filters the proposal describes.
Why it matters
You have to know where a model came from before you can look for one. Answering "what can I use for image editing?" means reading This computer, then each connected server's group, then opening Add model and reading the catalog there, then the search box — four places, and again for each of the five slots. The one question a person actually has, "what can do this job", is the one the layout cannot answer.
It is also the last piece holding several docs in a transitional state. This page opens by saying the one screen with Source and Capability filters is still to come and that the page moves to model-catalog/local.md when it does; connections.md says the same from its side. Until this ships, three architecture docs describe an interim shape.
Where
docs/proposals/model-catalog.md— read this first. The screen section and step 6 of Order of work are the design; this issue is that step, not a fresh one. Steps 1 to 5 have shipped, which is why the backend already returns everything the filters need.surfsense_local/frontend/src/features/models/add-model/add-model-options.tsx— the two-section Add model page.surfsense_local/frontend/src/features/models/your-models/local-models-group.tsxandremote/models/server-models.tsx— "This computer" and the per-server groups, the split itself.surfsense_local/frontend/src/features/settings/models/— the five per-slot settings pages that assemble those groups.- Reuse rather than rewrite: a row already carries
selectable_for,types,knownandengine, so the Capability filter is a filter over data the API already sends, andmodules/llm/selectable.pyis the one rule for which slots a model fills.ModelCard,BuildActionandInstallProgressare the row parts; they should survive the rework.
What done looks like
- One list of models with a Source filter (All, Local, Remote) and a Capability filter offering each type that has rows, plus Unknown when any row is unknown — as the proposal specifies.
- Hugging Face search stays its own box. That is deliberate and the proposal repeats it: what the user types goes to a third party, and it carries the egress question.
- This is large enough to split, and splitting it is welcome. Say in the PR which part of step 6 it is and what is still to come.
- The docs move with the work, and that is a real part of it: this page becomes
model-catalog/local.md,connections.mdkeeps storage, keys, the probe and the runtime, and the proposal is deleted when the last piece lands. Do only the part your change earns.
What not to change
Do not change what the API returns to make the screen easier. The rows are the finished part of this design — the backend decides and the screen renders, computing no fit, no default, no recommendation and no selectability. A filter that recomputes any of those in the renderer is the failure mode this whole design exists to avoid.
How to verify
The per-slot settings pages are covered by chat-models-settings.test.tsx, image-models-settings.test.tsx, audio-models-settings.test.tsx and their siblings, and the catalog itself by download-chat-models.test.tsx. The repo is TDD: write the failing test for each filter behaviour first.
cd surfsense_local/frontend
pnpm test
cd ../.. # this touches docs/, so check them from the repo root
python scripts/check_docs.py
Before you start
Read CONTRIBUTING.md, the model catalog proposal, this page's local model catalog doc, the connections doc and ADR 0014. React work follows the frontend-workflow skill, shadcn components the shadcn skill after it, and interface strings the translate skill, all in AGENTS.md. This is a large change: comment here with what you plan to take on before you start, so it can be split rather than collided with. Open your PR against dev, not main.
- Lingua principale
- Python
- Stelle
- 16.3k
- Fork
- 1.6k
- Merge medio
- 9h 22m
- PR unite (30g)
- 253
Preparare l'ambiente
Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di MODSetter/SurfSense
-
Run the frozen document-script packaging test in CIForse già presa Una pull request collegata a questa issue è aperta o già unita. Apertadesktop help wanted test
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
code quality security
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
desktop
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
desktop security
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
Write the ADR for chat modesApertaarchitecture desktop documentation
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di MODSetter/SurfSense
Issue simili
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
huggingface/smolagents#2976 ·
I maintainer di solito rispondono entro 1 giorno
-
bug Triage-Needed
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 66/100
FuRongJun-1999/dsh-memory#170 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
pgvector/pgvector-python#163 ·
-
[开源推荐] 打拼音就出篆书的输入法,附古文字创作小工具Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 82/100
521xueweihan/HelloGitHub#3940 ·