SEP 44's later commits haven't run on an AMD card

Aperta
  • Qualcosa non va?
#541 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@jtravs ci sta già lavorando.

Dal 5/11/2026.

  • #542 di @jtravs — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
cpp, python
Ambito
performance, testing-qa

Direzione di ricerca

Start with SEP 44 at #520 and the issue’s references to #298, #504, and #529 to understand the checks and their expected outcomes. On an AMD Instinct MI300X or MI325X, build with HIP and tests, then run the listed GPU tests, whole scan, hard-edge fuzz, rocFFT work area checks, and python -m benchmarks.device_split 768. Done means recording those results, including whether the fuzz fails and the device-specific benchmark figures.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

What's missing

SEP 44 (#520) qualified on an AMD Instinct MI325X at 9a5d2346, with a HIP build for AMD_GFX942 under ROCm. Its later commits have run on an NVIDIA H200 and an NVIDIA A40, and the HIP build with its tests compiles at the head, but no AMD card has run them: a rented MI325X had no capacity for a day, and an MI300X failed twice before it started. The maintainer set SEP 44 Final without that pass.

The only C++ changed since 9a5d2346 keeps a device's split collar at the node chunk, which the MI325X had already measured (2.2 % of a step, in the ledger's "A device step beyond its transforms"), and answers the native lint and tidy lanes.

What to run on an AMD card

At #520's merge or later, with a HIP build and tests:

  1. pytest -m gpu over tests and over native/tests, which ran at 9a5d2346 only.
  2. A whole scan on a kept backend, the change that keeps a device's backend across a local scan's input-only points (#298). It has run on the NVIDIA A40 only.
  3. The hard-edge fuzz (#504), with the far field's clang fp contract(off) pragma removed as on #497's base. It should fail there. If it passes, the fuzz can't see the bug it was written for on HIP.
  4. rocFFT's work area per plan, for #529's table, and whether rocFFT's plans of the scratch can share one work area, as cuFFT's do.
  5. python -m benchmarks.device_split 768, §7's gates, at the head, as a check against the MI325X's figures at 9a5d2346.

An AMD Instinct MI300X (gfx942) serves as well as an MI325X for 1 to 4. The figures in 5 belong to the card they ran on.

Lingua principale
Python
Stelle
3
Fork
3
Merge medio
6h 51m
PR unite (30g)
136

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di LupoLab/solprop

Tutte le issue di LupoLab/solprop

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.