Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Register Signature Rejection in Policy Workbench and add flow tests

Aperta
  • Qualcosa non va?
#8,689 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
68/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
playwright, typescript
Ambito
frontend, testing

Direzione di ricerca

Start with the existing registration pattern in src/views/Settings/PolicyWorkbench/settings/realDefinitions.ts, then inspect the Workbench flow and existing save-error tests/helpers. Verify the existing engine and policy module support loading, saving, reloading, resetting, hidden helper policies, and backend errors without changing useRealPolicyWorkbench.ts or policyWorkbenchCompoundPolicies.ts. Run the focused integration and Playwright scenarios, followed by npm run lint and npm run ts:check.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

frontend good first issue javascript

Part of #8685. Blocked by #8688.

Goal

Register the completed Signature Rejection policy module in Policy Workbench and verify that it works through the existing Workbench flow.

Do not add Signature Rejection rules to the shared engine.

Registration

Add only the parent definition to:

src/views/Settings/PolicyWorkbench/settings/realDefinitions.ts

Parent key:

rejection_enabled

The four helper policies must not appear as separate catalog entries.

Use the existing registration pattern.

Workbench integration

Use the engine completed by #8687 and the policy module completed by #8688.

Do not modify useRealPolicyWorkbench.ts or policyWorkbenchCompoundPolicies.ts just to register Signature Rejection. If registration requires Signature Rejection-specific engine logic, stop: that means #8687 is incomplete.

Use the engine that already exists.

Verify that the registered policy can be:

  • loaded;
  • edited;
  • saved;
  • reloaded;
  • reset/removed.

Do not add separate inheritance, delegation or authorization logic.

Backend validation errors must stay visible through the existing Workbench error flow.

Do not mock frontend-only permission rules. For a validation-error test, mock the backend request failure in the same way existing Workbench save-error tests do.

Focused integration tests

Cover:

  • Signature Rejection appears once in the catalog;
  • helper policies stay hidden;
  • a saved system rule restores all five values after reload;
  • one group or user rule uses the same generic flow;
  • a backend validation error is displayed and is not reported as a successful save.

Do not reproduce the backend validation matrix in frontend code or tests.

Playwright

Add one focused Policy Workbench scenario:

  1. open Signature Rejection;
  2. configure a system rule;
  3. save;
  4. reload;
  5. verify the five values are restored.

Reuse existing Policy Workbench helpers.

A second Playwright scenario is not required unless an existing helper makes a group/inherited case small and stable.

Done when

  • Signature Rejection appears once in the catalog.
  • Helper policies stay hidden.
  • Save + reload restores all five values.
  • One non-system rule is covered by focused integration tests.
  • Backend save errors remain visible.
  • The focused Playwright scenario passes.
  • npm run lint passes.
  • npm run ts:check passes.

Good first issue

The policy module and generic compound support are complete before this issue starts. This task only registers the module and verifies the existing Workbench behavior.

Lingua principale
PHP
Stelle
818
Fork
146
Merge medio
7h 38m
PR unite (30g)
490

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di LibreSign/libresign

Tutte le issue di LibreSign/libresign

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.