Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Radio: an empty ICY StreamTitle blanks the playbar subtitle

Aperta Adatta ai principianti
  • Qualcosa non va?
#820 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
86/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
audio-video-rtc, cli

Direzione di ricerca

Inizia da src/infra/radio/stream.rs, dove la callback IcyMetadataReader, intorno alla riga 157, salva meta.stream_title() così com'è nella cella now_playing. Aggiungi l'helper puro clean_stream_title descritto nell'issue e fai passare quella riga attraverso di esso, lasciando invariata la guardia if let Ok(meta). Esegui cargo test --no-default-features --features telemetry,tui,internet-radio stream_title e verifica che i quattro nuovi test compaiano come superati, e non solo filtrati.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug good first issue

What

A lot of internet radio stations send an empty now-playing title between songs, during ads or jingles, and some send one all the time. On the wire that's StreamTitle=''; (and sometimes StreamTitle=' - ';). When that happens, the line under the station name in the radio playbar goes blank, or shows a bare -. The "artist" we hand to the OS media integrations (MPRIS, Windows media controls, macOS Now Playing, Discord) goes blank too.

How to reproduce:

  1. Build with radio support: cargo run --no-default-features --features telemetry,tui,internet-radio (no Spotify account needed).
  2. Pick the Radio source and tune in to a station. Stations that send empty titles between tracks or during ad breaks show it best.
  3. Watch the subtitle line in the playbar. When the station sends an empty title, the subtitle goes empty.

What should happen instead: when there's no real title, the subtitle should fall back to the station's genre tags, or to its country/codec/bitrate summary when there are no tags. The code already does this when the title is missing (None). It doesn't do it when the title is present but empty (Some("")).

The cause: the icy-metadata crate (0.6) turns StreamTitle=''; into Some(""), and our metadata callback stores that value as is. Both readers only fall back on None, so the empty string wins.

Where to look

  • src/infra/radio/stream.rs, open_radio_stream. Line 146 creates the shared cell let now_playing: Arc<Mutex<Option<String>>> = Arc::new(Mutex::new(None));. Lines 150-163 build the IcyMetadataReader, and its callback (lines 153-162) is the only place the cell gets written: 
    move |meta| {
  // (existing comment about parse errors)
  if let Ok(meta) = meta {
    let title = meta.stream_title().map(str::to_owned);
    if let Ok(mut np) = cell.lock() {
      *np = title;
    }
  }
},
    Line 157 is the one to change. meta.stream_title() returns Option<&str>.
  • src/infra/radio/mod.rs, lines 93-95: now_playing_title() just clones whatever is in the cell. You don't need to change it.
  • src/tui/ui/player.rs, draw_radio_playbar (starts at line 997). Lines 1003-1009 only fall back when the title is None: 
    let artists = radio.now_playing_title().unwrap_or_else(|| {
  if radio.station.artists.is_empty() {
    radio.station.album.clone()
  } else {
    radio.station.artists.join(", ")
  }
});
  • src/infra/media_metadata.rs, line 304: the same expression for the OS integrations.
  • src/infra/radio/stream.rs, mod tests (lines 178-282): it has two network tests, live_stream_opens_with_icy_metadata and live_stream_plays_through_sink. Both are #[ignore], so a normal cargo test never touches the network. Your new tests go in this module.

Possible solution

  • Add a small pure function in src/infra/radio/stream.rs (above the #[cfg(test)] module is a good spot) that turns the raw title into the value we want to store:

    /// The title to show, or `None` when the station sent a blank one.
fn clean_stream_title(raw: Option<&str>) -> Option<String> {
    let trimmed = raw?.trim();
    if trimmed.chars().all(|c| c == '-' || c.is_whitespace()) {
        None
    } else {
        Some(trimmed.to_string())
    }
}

    all on an empty string returns true, so "" is covered too. Then change line 157 to let title = clean_stream_title(meta.stream_title());.

  • Fix it at this one write site only. Both readers (the playbar and media_metadata.rs) and anything else that reads the cell then fall back correctly with no other change. Please don't add a second cleanup in now_playing_title() or in the readers. One cleaning point is enough.

  • Keep the if let Ok(meta) = meta guard exactly as it is: a block that fails to parse must still keep the last good title. Only a block that parses fine but carries an empty title should clear the cell to None. That matches what already happens today for a block with no StreamTitle at all.

  • A station whose real title is literally - loses it. That's fine.

  • Leave the existing comments alone. Also don't touch the connect/header/probe timeouts in this file (src/infra/radio/AGENTS.md explains why they're there).

  • The whole radio module sits behind the internet-radio feature, so the plain slim build doesn't compile your change at all. Build and test with internet-radio on.

  • Tests: add plain #[test] functions (not tokio::test, there's nothing async here) to mod tests in stream.rs. They need no network, account or audio device. Suggested names:

    • empty_stream_title_clears_to_none: clean_stream_title(Some("")) and clean_stream_title(Some(" ")) give None
    • dash_only_stream_title_clears_to_none: Some(" - ") and Some("-") give None
    • missing_stream_title_stays_none: None gives None
    • real_stream_title_is_trimmed_and_kept: Some(" Daft Punk - Get Lucky ") gives Some("Daft Punk - Get Lucky".to_string())

    Keep the word stream_title in every test name so the filter below picks them all up.

  • CI runs clippy on the bin target only, so run cargo test to compile test code.

  • Leave tools/gates.count alone, new tests need no counter change.

Done when

  • cargo test --no-default-features --features telemetry,tui,internet-radio stream_title runs your new tests and they pass. A filter that matches nothing still exits 0, so check the count: the summary should list your tests as passed, not just "N filtered out".
  • Manual check (no Spotify account needed): run cargo run --no-default-features --features telemetry,tui,internet-radio, tune in to a station that sends empty titles between songs, and check that the playbar subtitle shows the station's tags or summary instead of going blank.
  • cargo fmt --all -- --check, cargo clippy --no-default-features --features telemetry,tui -- -D warnings and cargo test --no-default-features --features telemetry,tui pass, plus cargo clippy --no-default-features --features telemetry,tui,internet-radio -- -D warnings and the internet-radio test command above.
Lingua principale
Rust
Stelle
1.4k
Fork
238
Merge medio
9h 19m
PR unite (30g)
186

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di LargeModGames/spotatui

Tutte le issue di LargeModGames/spotatui

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.