Native scripts nested past about 660 levels break getUtxos

Aperta
  • Qualcosa non va?
#684 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
api, backend

Direzione di ricerca

Start with NativeScripts.ts:335-359 and NativeScripts.ts:368,423,432,441 to trace recursive validation and decoding; compare the cold and warmed depth measurements in the issue. Then inspect the listed provider call sites and error handlers in BlockfrostEffect.ts, Koios.ts, KoiosEffect.ts, Maestro.ts, and KupmiosEffects.ts. Done means ledger sized scripts decode in linear time and provider read failures surface as ProviderError; the issue names no test file.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

NativeScripts.fromCBORHex("820181".repeat(670) + "820400"), an all script nested 670 levels deep in 2,013 bytes, throws RangeError: Maximum call stack size exceeded on a first call in a fresh process. At 660 levels it decodes. Once the code is warm, 1,200 levels decode and 2,500 fail. Decoding time grows with the square of the depth: 0.2 s at 100 levels, 0.9 s at 200, 2.7 s at 400 and 6.3 s at 600, all wall clock. The limits are the same before and after #677.

With fetch stubbed to return a UTxO whose reference script is such a script nested 2,000 levels, getUtxos fails on Blockfrost, Koios, Maestro and Kupmios. In each case the exit holds the RangeError as a defect, an untyped failure, not a ProviderError, so catchAll handlers never see it.

NativeScripts.FromCDDL (NativeScripts.ts:368) type-checks its input against the recursive CDDLSchema union (NativeScripts.ts:335-359) and its output against NativeScript. It decodes each nested script with a fresh ParseResult.decode(FromCDDL) (NativeScripts.ts:423, 432, 441), which type-checks that subtree again. Each level adds call frames to one recursion and repeats the checks for everything below it. The providers call the decoder inside Effect.map or Effect.gen bodies, where a thrown error becomes a defect that Effect.catchAll does not catch:

  • Blockfrost: BlockfrostEffect.ts:190-195, past the handlers at BlockfrostEffect.ts:306 and BlockfrostEffect.ts:345
  • Koios: Koios.ts:215, called from Koios.ts:257, past KoiosEffect.ts:94
  • Maestro: Maestro.ts:307, called from MaestroEffect.ts:104
  • Kupmios: KupmiosEffects.ts:131-139, past KupmiosEffects.ts:156

The ledger decodes native scripts with no depth limit (cardano-ledger d0e20888, Allegra/Scripts.hs:226-236; Conway uses the same Timelock type, Conway/Scripts.hs:74). A nested all costs 3 bytes, so one 16,384-byte transaction can create a reference script about 5,400 levels deep. Anyone can put such a script in a UTxO at any address, and getUtxos() then fails for the whole address. #662 describes the same failure for inline datums.

NativeScripts.fromCBORHex should decode any native script the ledger accepts in time linear in its size, and a provider that cannot read a UTxO should fail with a ProviderError.

Lingua principale
TypeScript
Stelle
22
Fork
33
Merge medio
21h 38m
PR unite (30g)
55

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di IntersectMBO/evolution-sdk

Tutte le issue di IntersectMBO/evolution-sdk

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.