Extend CodeQL to the actions language and settle the query suite

Aperta
#341 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 4 giorni

@IanoNjuguna ci sta già lavorando.

Dal 22/11/2026.

  • #415 di @IanoNjuguna — aperta

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
70/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
github-actions, yaml

Direzione di ricerca

Start with .github/workflows/codeql.yml, add the issue's actions analysis configuration, and run the workflow against .github/workflows/. Record the default-suite and security-extended alert counts, triage the actions findings, and document the code-scanning dismissal policy in TRIAGE.md. Done means actions analysis runs, the query-suite decision and comparison numbers are recorded, and the dismissal policy states who may dismiss alerts and which reason codes are allowed.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement Medium Priority Security

Problem statement

Follow-up to #298 and the workflow merged in #335.

#298 asked for SAST covering "the website (JS/TS) and workflow/config surfaces". The workflow that landed in #335 covers the first half only: a matrix entry for javascript-typescript, which extracts 274 files from website/** and scripts/ and reports 0 findings against 87 rules.

The workflow half was assumed to need a different tool. It does not: CodeQL ships an actions language with its own extractor and security queries (github/codeql/actions/ql/src/Security), covering CWE-094 (code injection in workflows), CWE-829 (unpinned or third-party actions), CWE-312 (cleartext credentials), plus CWE-275, CWE-285 and CWE-349.

Nothing in this repo analyses .github/workflows/, which is the highest-privilege code here: deploy.yml holds pages: write and id-token: write.

Separately, the query suite was never chosen, only defaulted. The baseline is 87 rules and 0 results, which is a clean starting point but says nothing about what security-extended would surface.

Proposed solution

  1. Add - language: actions with build-mode: none to the matrix in .github/workflows/codeql.yml, run it, and confirm whether this repo's workflows analyse cleanly without extra configuration.
  2. Run security-extended on a throwaway branch and compare the alert count with the default suite. Decide, and record the numbers in this issue.
  3. Add the dismissal policy to TRIAGE.md: who may dismiss a code scanning alert, and which reason codes are acceptable.

If the actions queries turn out to be thin, the fallback is actionlint in CI for syntax and shellcheck, and zizmor for workflow security rules. Do not add a second scanner before testing the one already being installed.

Scope and impact

One matrix line plus a comparison run. The risk is noise: if security-extended or the actions queries produce a wall of findings, the gate gets ignored, so the baseline has to be triaged before either change lands as a default.

Acceptance criteria:

  • actions analysis runs and its findings are triaged
  • Query suite chosen, with the comparison numbers recorded here
  • TRIAGE.md states the dismissal policy for code scanning alerts
Lingua principale
TypeScript
Stelle
13
Fork
24
Merge medio
2g 3h
PR unite (30g)
16

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di IntersectMBO/developer-experience

Tutte le issue di IntersectMBO/developer-experience

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.