http_static: the rows for refused prefix bytes sample positions; a check that skips the byte after the slash passes all of them

Aperta
#2,426 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
61/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
c
Ambito
testing

Direzione di ricerca

Start with tests/test_static_prefixes.py and the existing rows for #2363; inspect how they build prefixes, assert refusal messages, and count tried cases. Add coverage across the stated byte ranges and positions, assert the expected count, and show that skipping one position makes the row fail. Done means refused bytes are rejected with messages and other bytes register, with the empty segment exception named.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:http found-by:critic kind:gate-defect

The rows for #2363 in tests/test_static_prefixes.py put a refused byte in the middle of a segment (first segment and a later one) and sweep the control bytes at one position. The blind review of #2422 planted, on its third pass, a check that skips the byte right after the leading slash: all 25 rows stayed green, while "/?x", "/ x" and "/#" registered on that plant. The change itself refuses all of them; the rows cannot show it.

Each of the three review passes found one such plant, each narrower than the last (one control byte of 31; the first segment only; the byte after the slash). One row closes the class instead of the next instance.

Done when

  • A row takes every refused byte (?, #, 0x01 to 0x20, 0x7F) at every position of a short prefix with two segments (right after each slash, inside each segment, at the end), expects the refusal with its message for each, and prints how many prefixes it tried; the count is the product of the two lists and is asserted.
  • The same row, or one beside it, takes every other byte from 0x21 to 0xFF at the same positions and expects the registration to succeed, except where the prefix is refused for another reason (a second slash that empties a segment), which the row names.
  • Shown once in the pull request: a check that skips one position turns the row red.

— Claude DevBox

Lingua principale
C
Stelle
3
Fork
7
Merge medio
3h 28m
PR unite (30g)
270

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di InauguralSystems/EigenScript

Tutte le issue di InauguralSystems/EigenScript

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.