Get USGS timeseries doesn't remove trailing whitespaces from USGS station number.

Aperta Adatta ai principianti
  • Qualcosa non va?
#258 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Tranquilla
Stack tecnologico
python
Ambito
cli

Direzione di ricerca

Inizia da cwmscli/usgs/init.py e segui getusgs_cda.py, in particolare getusgs_timeseries, getusgs_cda e getUSGS_ts. Traccia come viene costruito l’elenco delle stazioni dall’alias Location Group - USGS Station Number e riproduci la richiesta con spazi finali. Il lavoro è completo quando i numeri delle stazioni vengono ripuliti prima della costruzione dell’URL USGS e la richiesta non contiene più spazi codificati.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug
CLI Script

getusgs-timeseries

Describe the bug

Cwms-cli usgs timeseries does not strip the trailing whitespaces from the Alias when building the station list from "Location Group - USGS Station Number".

If trailing whitespaces are present, the URL that is built will contain "++++" causing it to fail:

example:

2026-08-11 14:14:29;DEBUG;Starting new HTTPS connection (1): waterservices.usgs.gov:443
2026-08-11 14:14:30;DEBUG;https://waterservices.usgs.gov:443 "GET /nwis/iv/?format=json&sites=08330830+++++++%2C09357000+++++++%2C08401450%2C08302500+++++++%2C384048104504901%2C08289000%2C07130000%2C07124410%2C07124400%2C08263500%2C09363500%2C07134990%2C09432000%2C08277470%2C08287000%2C07099238%2C384037104472001%2C07138075%2C07138063%2C08385503%2C07227100%2C08265000%2C07103703%2C383619104520401%2C07138050%2C07137000%2C07226500+++++++&startDT=2026-08-10T14%3A14%3A24.500202&endDT=2026-08-11T16%3A14%3A24.500202&access=3&siteStatus=active HTTP/1.1" 400 503

Unexpected error. Report it at https://github.com/HydrologicEngineeringCenter/cwms-cli/issues/new?template=bug-report.yml
Traceback (most recent call last):
  File "/wm/spa/l4cwpa43/.local/lib/python3.9/site-packages/requests/models.py", line 976, in json
    return complexjson.loads(self.text, **kwargs)
  File "/wm/wmsoft/python/v3.9.18-Solaris11.4.86.201.2/lib/python3.9/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/wm/wmsoft/python/v3.9.18-Solaris11.4.86.201.2/lib/python3.9/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/wm/wmsoft/python/v3.9.18-Solaris11.4.86.201.2/lib/python3.9/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/wm/spa/l4cwpa43/.local/bin/cwms-cli", line 6, in <module>
    sys.exit(main())
  File "/wm/spa/l4cwpa43/.local/lib/python3.9/site-packages/cwmscli/__main__.py", line 119, in main
    cli(standalone_mode=False)
  File "/wm/spa/l4cwpa43/.local/lib/python3.9/site-packages/click/core.py", line 1161, in __call__
    return self.main(*args, **kwargs)
  File "/wm/spa/l4cwpa43/.local/lib/python3.9/site-packages/click/core.py", line 1082, in main
    rv = self.invoke(ctx)
  File "/wm/spa/l4cwpa43/.local/lib/python3.9/site-packages/click/core.py", line 1697, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/wm/spa/l4cwpa43/.local/lib/python3.9/site-packages/click/core.py", line 1697, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/wm/spa/l4cwpa43/.local/lib/python3.9/site-packages/click/core.py", line 1443, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/wm/spa/l4cwpa43/.local/lib/python3.9/site-packages/click/core.py", line 788, in invoke
    return __callback(*args, **kwargs)
  File "/wm/spa/l4cwpa43/.local/lib/python3.9/site-packages/cwmscli/utils/deps.py", line 111, in wrapper
    return func(*args, **kwargs)
  File "/wm/spa/l4cwpa43/.local/lib/python3.9/site-packages/cwmscli/usgs/__init__.py", line 54, in getusgs_timeseries
    getusgs_cda(
  File "/wm/spa/l4cwpa43/.local/lib/python3.9/site-packages/cwmscli/usgs/getusgs_cda.py", line 88, in getusgs_cda
    USGS_data_method = getUSGS_ts(method_sites, startDT, endDT, 3)
  File "/wm/spa/l4cwpa43/.local/lib/python3.9/site-packages/cwmscli/usgs/getusgs_cda.py", line 272, in getUSGS_ts
    r = requests.get(base_url, params=query_dict).json()
  File "/wm/spa/l4cwpa43/.local/lib/python3.9/site-packages/requests/models.py", line 980, in json
    raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
REDACTED relevant log output
Steps to Reproduce

No response

Lingua principale
Python
Stelle
3
Fork
5
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di HydrologicEngineeringCenter/cwms-cli

Tutte le issue di HydrologicEngineeringCenter/cwms-cli

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.