Hidden tabs: decide whether opening one from its URL redirects, consistently

Aperta
  • Qualcosa non va?
#2,062 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
78/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
react, typescript
Ambito
frontend, web-dev

Direzione di ricerca

Read src/features/instance/applications/routes.ts and ApplicationsIndex.tsx alongside src/features/instance/extensions/DESIGN.md and useInstanceNavLinks.tsx to trace the current hidden tab behavior. Compare direct navigation to / and /apps with other hidden tab URLs, then apply the chosen redirect rule consistently. Done means the instance and cluster routes follow one documented rule.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Focused navigation (studio#2031) lets a cluster mark a built-in tab hidden. Hiding is focus, not security: a hidden tab disappears from the nav and from /start's choices, but its URL still opens it.

One built-in tab behaves differently. On a local or instance Studio, the root index (/) redirects away from Applications when Applications is hidden, because / is the default entry URL there. A cluster's /apps has no such redirect, so a typed URL, a bookmark or history opens the editor even when the cluster hides Applications. Every other hidden tab (/operations, /apis, …) also opens from its URL, so the inconsistency is only between the instance index and cluster /apps. Nothing in Studio links to a hidden /apps: the nav drops the tab and /start never lands on it.

Decide one rule and apply it everywhere. Either a hidden tab redirects to /start whenever it is opened directly, or none do and the instance index redirect is the only exception, documented as the entry-URL case. The code is in src/features/instance/applications/routes.ts and ApplicationsIndex.tsx; the visibility rules are in src/features/instance/extensions/DESIGN.md and useInstanceNavLinks.tsx.

Review-Deferral: 8af3368bcf37c858 severity=nit category=correctness

Lingua principale
TypeScript
Stelle
5
Fork
4
Merge medio
1g 19h
PR unite (30g)
144

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di HarperFast/studio

Tutte le issue di HarperFast/studio

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.