Sign-out: a logout to each marked URL carries the one stored Basic Auth credential

Aperta
#1,971 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript

Direzione di ricerca

The payload names no files. Start by finding where the per-entity Basic Auth credential is saved and where sign-out loops over the URLs an entity is marked at, which is the logic added in #1969. Choosing between the two fix directions needs a maintainer decision first. Done when a logout to a URL the credential was not entered for is sent without that credential, with a test covering it.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

What happens

Studio stores one Basic Auth credential per entity (a cluster or instance), not per URL. A sign-in marker records the URL signed into, and an entity can end up marked at more than one URL, for example after its domain changes. When a sign-out logs out each URL an entity is marked at (#1969), every one of those logout requests carries that single stored credential, including to a URL it was never used with.

Why it's small

The URLs belong to the same entity, and the request is a logout. But a credential going to a host it wasn't entered for is worth closing.

Fix direction

Either store the credential with the URL it was entered for and send it only there, or send the logout with the credential only to the URL the credential was saved for, and without it to the others.

Review-Deferral: face1e3da4c920f7 severity=nit category=security

Raised by the cross-model review of #1969 (#1968). Pre-existing; not introduced there.

🤖 Generated by Anthropic Claude Code (Claude Opus 5.5); posted via @dawsontoth.

Lingua principale
TypeScript
Stelle
5
Fork
4
Merge medio
1g 20h
PR unite (30g)
140

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di HarperFast/studio

Tutte le issue di HarperFast/studio

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.