Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

nomos status --poll-until: follow-ups after #2242

Aperta
  • Qualcosa non va?
#2,326 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go, kubernetes
Ambito
cli, documentation, testing

Direzione di ricerca

Start with the nomos status --poll-until implementation and its pollUntilReached unit tests; the issue also names TestNomosStatusPollUntil and the checkConflict constant as entry points. Work through the correctness and cluster failure cases first, then the UX, tests, and design doc checklist. Done means the listed follow-ups are implemented, covered by tests, and the help text and design doc are updated.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement
Checklist
  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.
Describe the feature

Follow-up to #2242 (which fixes #2006). These items were deferred to keep the 1.26 change minimal.

Correctness

  • Treat a RootSync/RepoSync whose status.observedGeneration != metadata.generation as not synced. Right after a spec change, the previous SYNCED status can be reported briefly.
  • current: treat Conflict resources like Failed, using a constant shared with checkConflict.
  • current: when resource status is disabled (spec.override.statusMode: disabled, which annotates the ResourceGroup with configsync.gke.io/status: disabled), fail fast with an error that points to --poll-until=synced. Check resourcegroup.IsStatusDisabled(rg) before the ResourceGroup freshness check below. These ResourceGroups have no resourceStatuses and keep status.observedGeneration at 0, so today current passes as soon as the sync is SYNCED, and the freshness check alone would make it poll forever. (Raised by @Camila-B.)
  • current: skip resource checks while the ResourceGroup's status.observedGeneration != metadata.generation.
  • Check clusters in sorted order and report all failures with errors.Join, instead of returning on the first one.

Clusters that can never complete

  • Fail fast on mono-repo clusters (ErrMonoRepoFound).
  • Fail fast on, or retry, clusters that were unreachable at startup. Their clients are never re-created, and --contexts defaults to all contexts.
  • Decide how to handle clusters without Config Sync installed. Today they keep polling until the external timeout.

UX, tests, docs

  • Don't run clear between polls when stdout isn't a terminal, so CI logs stay clean.
  • Merge the pollUntilReached unit tests into one table-driven test.
  • Extend TestNomosStatusPollUntil to cover a Failed resource.
  • Update the --poll help text: "If neither --poll nor --poll-until is set, the command runs only once."
  • Rename the design doc to "Poll until status is current", and document the status lag right after a push or spec change.
Importance

No response

Lingua principale
Go
Stelle
279
Fork
59
Merge medio
1g 23h
PR unite (30g)
12

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di GoogleContainerTools/config-sync

Tutte le issue di GoogleContainerTools/config-sync

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.