Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Duplicate cached thumbnails based on grid column width

Aperta
  • Qualcosa non va?
#1,127 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
android, kotlin
Ambito
mobile, performance

Direzione di ricerca

Start in app/src/main/kotlin/org/fossify/gallery/extensions/Context.kt, the location the issue identifies for overriding thumbnail request options. Reproduce with a clean cache, a grid column count that does not divide the screen width, then reverse the sort and compare cached thumbnail sizes. Done means the same grid size no longer creates duplicate cache entries differing by 1px; consider whether folder thumbnails show the same behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug needs triage
Checklist
  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.
Affected app version

1.13.1

Affected Android/Custom ROM version

Android 16

Affected device model

Pixel 10 (emulated)

How did you install the app?

Built from source

Steps to reproduce the bug
  1. Start with a clean cache.
  2. In the media grid use a column count that is not divisible by screen width.
  3. Take note of the current cached thumbnails and their resolution.
  4. Sort the media grid in the opposite direction.
  5. Look at the cache again, new entries have been created that have a 1px difference in resolution.
Expected behavior

App does not cache thumbnails twice for the same grid size.

Actual behavior

When tiles move in the media grid from one column to another there is a chance it creates a new cache entry that has a 1px size difference. This depends on if the screen width is divisible by the column count.
For example a screen with a width of 1080px and a column count of 7 creates cached thumbnails with sizes 152px and 153px. If a tile then moves to a column with a different width a new thumbnail is created.

The problem can be more or less noticeable depending on the screen resolution.
By estimation, not actually tested each resolution:

Resolution (vertical) Appears with column count
1080x2424 (Pixel 10) 7...
1440x3120 (S25 Ultra) 7...
1220×2656 (Xiaomi 17) 3, 6, 7...
Screenshots/Screen recordings

No response

Additional information

The problem likely appears for folder thumbnails too.

Potential fix could be to calculate what the thumbnail resolution should be when columns change and round the result. Then pass that as an override to RequestOptions in app/src/main/kotlin/org/fossify/gallery/extensions/Context.kt

Tested with square thumbnails, no rounded corners, thumbnail spacing 1px.
Grid and tile padding affect thumbnail size too.

Lingua principale
Kotlin
Stelle
3.8k
Fork
270
Merge medio
1g 7h
PR unite (30g)
13

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di FossifyOrg/Gallery

Tutte le issue di FossifyOrg/Gallery

Issue simili

Altre issue su Kotlin

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.