Empty results table tells you to open a project when a project is already open

Aperta
#61 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
74/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
dart, flutter

Direzione di ricerca

Start in lib/features/dashboard/widgets/dashboard_no_rows.dart; check how DashboardNoRows decides to show l10n.dashboardEmpty and where the loaded-project state is available. Add a separate ARB key for the project-open/no-results case in app_en.arb, app_zh_CN.arb, app_zh.arb, app_ja.arb and app_ko.arb, reusing the existing run-action label. Extend the dashboard widget test to assert both empty states in every locale; done means distinct correct copy for each state.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Found while smoke-testing the 1.2.0 builds on Windows.

With a project loaded and no run yet, the Results table is empty and says "No results yet. Open a project to begin a regression." A project is already open, so the instruction is wrong for that state.

Where: lib/features/dashboard/widgets/dashboard_no_rows.dart. DashboardNoRows shows l10n.dashboardEmpty whenever the filter is unset or no results exist. It does not look at whether a project is loaded. The string is dashboardEmpty in lib/l10n/app_en.arb, and every locale carries the same "open a project" wording: app_zh_CN.arb, app_zh.arb, app_ja.arb, app_ko.arb.

Likely fix: split the empty state in two. With no project open, keep the current prompt. With a project open and no results, say so and point at the action that starts a run (for example "No results yet. Run the project to see results here."), using the menu path or button label from the same ARB so it is speakable. This needs a new key in all five ARBs in the same change (app_zh.arb mirrors app_zh_CN.arb), and the dashboard widget test should cover both states in every locale.

Related, already fixed: #16 added the "filters hide every result" state. This is the remaining case, where nothing has run yet but a project is open.

Found in 1.2.0.

Lingua principale
Dart
Stelle
0
Fork
0
Merge medio
2g 10h
PR unite (30g)
3

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Ferrite-Engineering/simcrux

Tutte le issue di Ferrite-Engineering/simcrux

Issue simili

Altre issue su Dart

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.