Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Only the error paths of one tool are tested

Chiusa
  • Qualcosa non va?
#421 8 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 3 giorni

@AGWAM001 ci sta già lavorando.

Dal 17/10/2026.

  • #436 di @sparkysolutions10-pixel — aperta
  • #491 di @AGWAM001 — chiusa senza merge
  • #522 di @AGWAM001 — chiusa senza merge
  • #524 di @AGWAM001 — aperta

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

area:testing difficulty:intermediate help wanted points:150 Stellar Wave
Background

tests/mcp.test.ts has four tests, all on paid_call:

should map signature expiration ledger error to ERR_EXPIRED_AUTHORISATION
should map missing trustline error to ERR_MISSING_TRUSTLINE
should map 402 rejected error to ERR_PAYMENT_REJECTED
should return successfully on a successful call

bazaar_search has no tests at all — not the query path, not the empty-result
path, not the non-2xx path. ListTools is never exercised, so a malformed tool
schema would ship unnoticed.

The four that exist also construct errors as plain strings, which is what makes
L215's text-matching fragility invisible to the suite.

What to build
  • Cover bazaar_search: with and without a query, empty results, non-2xx, a
    malformed body.
  • Cover ListTools: the advertised tools, and that each inputSchema is valid.
  • Cover the unknown-tool path.
  • Where an upstream error is simulated, use a shape resembling what the real
    library throws.
Acceptance criteria
  • bazaar_search has tests for success, empty, non-2xx and malformed body
  • ListTools is exercised and each schema validated
  • The unknown-tool path is covered
  • Simulated errors resemble real ones
  • The four existing tests still pass

Drips Wave · Complexity: Intermediate · 150 points

Repo: Divinity-Labs/Lens. The MCP server is src/mcp/server.ts
(BazaarMcpServer) with error codes in src/mcp/codes.ts. It is started by
npm run mcp:server → examples/mcp-server/run.ts, and there is an agent
example at examples/mcp-server/agent.ts. Tests are tests/mcp.test.ts.

Run the tests: npm test. The tests are vitest, not jest. A single file
is npx vitest run tests/mcp.test.ts.

Load test (prices) is already failing on main. Not your PR.

This surface signs with a real mainnet key. examples/mcp-server/run.ts
requires MCP_AGENT_SECRET_KEY_MAINNET and builds a signer for
stellar:pubnet. Anything you change here can move real money, so prefer
failing closed, and never log, echo or test with a real secret key.

Never elide an address, a contract id or a key in code, comments or
fixtures. A previous batch shortened a contract id and five contributors
invented plausible-looking ids to fill the gap. Write it in full or not at all.

An agent is the least able caller to notice a wrong answer. It will reason
over whatever it is handed, confidently. Prefer a structured error over a
best-effort result.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Lingua principale
TypeScript
Stelle
4
Fork
71
Merge medio
3g 15h
PR unite (30g)
157

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Divinity-Labs/Lens

Tutte le issue di Divinity-Labs/Lens

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.