Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

The MCP server's upstream call has no deadline and no error handling

Chiusa
  • Qualcosa non va?
#349 2 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@Wittig18 ci sta già lavorando.

Dal 16/10/2026.

  • #452 di @sparkysolutions10-pixel — aperta

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

area:mcp difficulty:easy help wanted points:100 Stellar Wave
Background

src/mcp/server.ts:83 fetches an endpoint with no timeout and no status check.
MCP tools are called by agents, which typically have their own timeout and will
retry — so a hung call here becomes repeated hung calls, each holding a
connection, with no upper bound.

An agent is also the caller least able to interpret a malformed response: it
will take whatever shape comes back and reason over it, so a 502 HTML error page
parsed as JSON becomes a confident wrong answer in a conversation.

What to build
  • A deadline on the call, using the same helper as L162 if that has landed, or
    AbortSignal.timeout directly if not.
  • Check the response status and content type before parsing.
  • Return a structured MCP error on failure — a tool error the agent can act on,
    not a thrown exception or a half-parsed body.
  • Make the failure message say which upstream failed and why.
Acceptance criteria
  • The call cannot hang indefinitely
  • Non-2xx and non-JSON responses are rejected before parsing
  • Failures surface as structured MCP tool errors
  • The error names the upstream and the reason
  • Tests cover timeout, non-2xx and non-JSON responses

Drips Wave · Complexity: Easy · 100 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Lingua principale
TypeScript
Stelle
4
Fork
71
Merge medio
1g 6h
PR unite (30g)
58

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Divinity-Labs/Lens

Tutte le issue di Divinity-Labs/Lens

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.