Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Redis going away is noticed once and never again

Chiusa
#345 2 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 3 giorni

@abdulrahmanj383-creator ci sta già lavorando.

Dal 16/10/2026.

  • #399 di @abdulrahmanj383-creator — integrata
  • #467 di @sparkysolutions10-pixel — chiusa senza merge

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

area:reliability difficulty:intermediate help wanted points:150 Stellar Wave
Background

src/index.ts falls back when the Redis-backed retention worker cannot start:

} catch (err) {
  console.warn('[lens] Snapshot retention worker skipped (Redis unavailable):', (err as Error).message)
  console.warn('[lens] Falling back to an in-process hourly prune')
  await Promise.allSettled([retentionQueue?.close(), retentionWorker?.close()])
  setInterval(() => { void safePrune() }, 60 * 60 * 1000).unref()
}

The fallback itself is good design. The problem is that it is decided exactly
once, at boot, and never revisited. If Redis is briefly unavailable during a
deploy, the process spends its entire life on the in-process path — and because
every instance does its own hourly prune, with more than one instance they
overlap. /status says nothing about which path is in use, so the degraded mode
is invisible.

What to build
  • Expose which retention path is active, through /status and a gauge.
  • Re-check Redis periodically and switch back to the queue when it returns,
    cancelling the interval cleanly.
  • Make the in-process prune safe to run concurrently across instances, or guard
    it so only one instance prunes.
  • Log the transition in both directions, at a level that is actually visible.
Acceptance criteria
  • The active retention path is visible without reading boot logs
  • Redis returning causes a switch back, with the interval cleared
  • Concurrent prunes across instances cannot corrupt or duplicate work
  • Both transitions are logged
  • A test covers the fallback and the recovery

Drips Wave · Complexity: Intermediate · 150 points


Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture.
A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.


Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Lingua principale
TypeScript
Stelle
4
Fork
71
Merge medio
3g 15h
PR unite (30g)
157

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Divinity-Labs/Lens

Tutte le issue di Divinity-Labs/Lens

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.