There is no readiness check, only a status page
I maintainer di solito rispondono entro 3 giorni
Valutazione
Questa issue non è ancora stata valutata.
Descrizione
Background
/status is the only health-ish endpoint. A platform needs two different
answers and they are not the same question:
- liveness — is this process wedged and in need of a kill? Must not depend on
Postgres or Redis, or a database blip restarts healthy processes in a loop. - readiness — should this process receive traffic yet? Must check that
migrations are applied and dependencies are reachable, so a starting instance
is not sent requests it will fail.
Lens starts ingesters, a Redis-backed retention worker and a websocket fanout
before it is genuinely able to serve, so the gap is real.
What to build
/live— no dependency checks, returns healthy if the event loop is turning./ready— checks Postgres and, where configured, Redis; returns unhealthy
until the app has finished booting.- Both
public: trueand allow-listed from rate limiting, as/statusis. - Neither should be expensive enough to matter when polled every few seconds.
Acceptance criteria
-
/livereturns healthy without touching Postgres or Redis -
/readyreturns unhealthy before boot completes and healthy after -
/readyreports unhealthy when Postgres is unreachable - Both are excluded from rate limiting and from
httpMetricsroute cardinality -
/statusis unchanged
Drips Wave · Complexity: Easy · 100 points
Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.
Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.
Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.
This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.
Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.
The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.
Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk
- Lingua principale
- TypeScript
- Stelle
- 4
- Fork
- 71
- Merge medio
- 3g 6h
- PR unite (30g)
- 144
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di Divinity-Labs/Lens
-
Webhook retries have no jitter, so failures synchroniseForse già presa @Richard-tobi l’ha presa 9 giorni fa. Apertaarea:reliability difficulty:easy help wanted points:100 Stellar Wave
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
Divinity-Labs/Lens#341 · 2 commenti · 1 assegnatario ·
I maintainer di solito rispondono entro 3 giorni
-
upsertPricePoints can synthesize an event id from the wall clock, breaking dedupeForse già presa Una pull request collegata a questa issue è aperta o già unita. Aperta
Difficoltà 3/5 1-2 giorni Idoneità per principianti 55/100
Divinity-Labs/Lens#620 ·
I maintainer di solito rispondono entro 3 giorni
-
GraphQL queries bypass the per-route scope their REST equivalents requireForse già presa @sparkysolutions10-pixel l’ha presa 2 giorni fa. Aperta
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
Divinity-Labs/Lens#618 · 1 commento ·
I maintainer di solito rispondono entro 3 giorni
-
area:tests automated live-spec-report
Difficoltà 4/5 3-5 giorni Idoneità per principianti 28/100
Divinity-Labs/Lens#606 · 2 commenti ·
I maintainer di solito rispondono entro 3 giorni
-
The key is accepted only as a bearer token, and nothing says soForse già presa @krsnak l’ha presa 8 giorni fa. Apertaarea:docs difficulty:easy help wanted points:100 Stellar Wave
Divinity-Labs/Lens#512 · 4 commenti · 1 assegnatario ·
I maintainer di solito rispondono entro 3 giorni
Tutte le issue di Divinity-Labs/Lens
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
grafana/profiles-drilldown#1212 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
grafana/traces-drilldown#980 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
openremote/openremote#3487 · 1 commento ·
-
triage:needs-human
Difficoltà 2/5 1-3 ore Idoneità per principianti 67/100
garrytan/gbrain#7635 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
coollabsio/jean#867 ·
I maintainer di solito rispondono entro 1 giorno