/status does not say whether ingestion is actually working
I maintainer di solito rispondono entro 1 giorno
Valutazione
Questa issue non è ancora stata valutata.
Descrizione
Background
/status is defined at src/api/rest.ts:72 and is the endpoint an uptime
monitor will poll. It answers from the process's own point of view. It does not
report whether any ingester is running, when each venue last produced a price,
or whether an ingester has been crash-looping — which means a service with every
ingester dead still returns a healthy /status and a green uptime check.
This is the issue that makes L163 and L165 useful: both produce information that
currently has nowhere to go.
What to build
Extend /status with per-venue, per-network ingestion health:
- Last successful write time per
(venue, network), and the age of it. - Whether that age exceeds an expected interval for that venue.
- Restart count and last crash message, if L165 has landed; design for it being absent.
- An overall verdict that an uptime monitor can alert on.
Keep the existing fields — callers depend on them. The route is public: true
and allow-listed from rate limiting in src/app.ts, so it must stay cheap: no
unbounded queries, and do not add a Horizon round-trip to it.
Acceptance criteria
-
/statusreports last-write age per venue and network - A stale venue is visibly distinct from a healthy one
- Existing response fields are unchanged
- The handler issues a bounded, small number of queries regardless of how many pairs exist
- A test asserts the stale case is reported as unhealthy
Drips Wave · Complexity: Intermediate · 150 points
Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.
Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.
Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.
This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.
Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.
The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.
Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk
- Lingua principale
- TypeScript
- Stelle
- 4
- Fork
- 71
- Merge medio
- 1g 6h
- PR unite (30g)
- 58
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di Divinity-Labs/Lens
-
Webhook retries have no jitter, so failures synchroniseForse già presa @Richard-tobi l’ha presa 3 giorni fa. Apertaarea:reliability difficulty:easy help wanted points:100 Stellar Wave
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
Divinity-Labs/Lens#341 · 2 commenti · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
SSRF guard re-resolves DNS at connect time, so rebinding is still possibleForse già presa @sparkysolutions10-pixel l’ha presa oggi. Apertaarea:security help wanted
Difficoltà 4/5 3-5 giorni Idoneità per principianti 48/100
Divinity-Labs/Lens#515 ·
I maintainer di solito rispondono entro 1 giorno
-
Admin routes are public and that is load-bearingForse già presa @sparkysolutions10-pixel l’ha presa oggi. Apertaarea:security difficulty:easy help wanted points:100
Difficoltà 4/5 3-5 giorni Idoneità per principianti 58/100
Divinity-Labs/Lens#514 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
A caller cannot see their own usageForse già presa @sparkysolutions10-pixel l’ha presa oggi. Apertaarea:api-quality difficulty:intermediate help wanted points:150
Difficoltà 4/5 3-5 giorni Idoneità per principianti 55/100
Divinity-Labs/Lens#513 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
The key is accepted only as a bearer token, and nothing says soForse già presa @krsnak l’ha presa 2 giorni fa. Apertaarea:docs difficulty:easy help wanted points:100 Stellar Wave
Divinity-Labs/Lens#512 · 3 commenti · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di Divinity-Labs/Lens
Issue simili
-
area:workflow bug ready-for-human
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 78/100
fil-donadoni/tolaria#6108 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
apache/rocketmq-dashboard#7234 ·
I maintainer di solito rispondono entro 3 giorni
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
vitest-dev/vitest#11656 ·
I maintainer di solito rispondono entro 1 giorno
-
e2e-failure ready-to-code
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
redhat-developer/rhdh-plugin-export-overlays#4460 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
ehmpathy/rhachet-roles-bhrain#655 ·
I maintainer di solito rispondono entro 1 giorno