A workspace member with several crate types fails builds of unrelated packages

Aperta
#9 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
58/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
build-system

Direzione di ricerca

Start by locating the client-side workspace crate-type check: the report says it runs before the daemon starts and appears to inspect every workspace member. Trace how cargo rustd build -p app selects packages, then compare that with the crate-type validation. Done means the unrelated ffi member no longer blocks app; the report also describes the expected behavior when ffi is a dependency.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

cargo rustd build -p <crate> fails for the whole workspace when any workspace member declares more than one crate type, for example crate-type = ["lib", "cdylib", "staticlib"]. The failing member does not need to be a dependency of the crate being built.

This pattern is common for crates that expose an FFI surface (UniFFI, cbindgen, JNI) and also keep a lib target for Rust consumers.

Reproduction

Environment: macOS arm64 (Darwin), rustd from the nightly release, Rust 1.99.0 with rust-src.

Create a workspace with two members. app is a plain binary. ffi is a library with three crate types. app does not depend on ffi.

Cargo.toml

[workspace]
members = ["app", "ffi"]
resolver = "3"

ffi/Cargo.toml

[package]
name = "ffi"
version = "0.1.0"
edition = "2024"

[lib]
crate-type = ["lib", "cdylib", "staticlib"]

ffi/src/lib.rs

pub fn add(a: u32, b: u32) -> u32 {
    a + b
}

app/Cargo.toml

[package]
name = "app"
version = "0.1.0"
edition = "2024"

app/src/main.rs

fn main() {
    println!("{}", 1 + 2);
}

Then run:

cargo +1.99.0 rustd build -p app

Actual result

error: `ffi` is built as `lib` and `cdylib` and `staticlib`, which the daemon does not link yet: it builds a `lib`, an `rlib` or a `bin` alone

Expected result

Either of these would help:

  1. Building app succeeds, because ffi is not in its dependency graph.
  2. If ffi is a dependency, rustd builds its lib target and ignores the cdylib and staticlib outputs when no requested target needs them.

Notes from isolating it

Variant Result
Both crates are workspace members, ffi has three crate types Fails, error above
ffi removed from members (so it is not in the workspace) cargo rustd build -p app succeeds
Both are members, ffi has the default crate type cargo rustd build -p app succeeds

So the check seems to run over every workspace member, not only the packages selected by -p or the dependencies of those packages. I have not read the source, so this is an inference from the behavior.

I also saw that the error is printed even when the daemon is not running (cargo rustd stop reports daemon: not running), so the check looks like it happens in the client before the daemon starts. This is from observation only.

Why it matters

The README already lists "workspace crates built as cdylib, dylib or staticlib" under "What is not supported", so I understand this is a known limit. The part that may be unintended is its reach. A workspace that ships an FFI crate next to other packages cannot use rustd at all today, even for packages that do not touch that crate. The README does not say that the check applies to the whole workspace.

Related: #1 (macOS support). The trivial workspace above builds and runs under rustd on macOS arm64 once ffi is excluded, which is useful data for that issue.

Happy to test a fix or a branch.

Lingua principale
Rust
Stelle
248
Fork
13
Merge medio
7h 52m
PR unite (30g)
5

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di DioxusLabs/rustd

Tutte le issue di DioxusLabs/rustd

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.