[Bug]: fw upgrade reinstalls the cross-host messaging toolkit (step 7b) on every run, with no way to opt out
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 52/100
Direzione di ricerca
Start with step 7b in lib/upgrade.sh (around lines 2536 and 2541), then check fw upgrade --help and lib/init.sh to understand the current behavior and the init/upgrade mismatch. The issue proposes several possible approaches, so clarify the opt-in or skip behavior before changing it. Done means projects that decline the toolkit do not have its files reinstalled on later upgrades, and the behavior is documented in the upgrade help or summary.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Bug Description
Step 7b of fw upgrade, "Doorbell+mail toolkit (T-1867)", copies every file under lib/templates/skills/ and lib/templates/scripts/ into the project (lib/upgrade.sh, lines 2536 and 2541): nine slash commands in .claude/commands/ and twelve scripts in a new project-root scripts/ directory. There is no flag and no config key to skip the step, and fw upgrade --help lists none.
A project that removes these files gets them back on the next upgrade. T-3955 (479edae) made the step keep a file the project has customised; it does not cover a project that does not want the toolkit at all.
Why it matters: in a confidential workspace where nothing is meant to leave the machine and TermLink is not installed, a toolkit whose purpose is cross-host agent messaging is unwanted. It arrives without being announced as such, and has to be removed by hand after every upgrade.
Also: fw init does not install these files (no reference to the two template directories in lib/init.sh), so init and upgrade disagree on what a project contains.
Steps to Reproduce
fw inita project..claude/commands/holdsresume.mdonly, and there is noscripts/directory.- Run
fw upgrade. Twenty-one files are created. - Delete them, then run
fw upgradeagain.
Observed on 1.8.3 (with upstream at the same commit, so the upgrade brought nothing else) and again when upgrading to 1.8.6.
Expected Behavior
The messaging toolkit is installed only when the project asks for it, and a project that declined it is not asked again on each upgrade.
Actual Behavior
[7b/10] Doorbell+mail toolkit (T-1867)
CREATED .claude/commands/agent-handoff.md — from template
CREATED .claude/commands/be-reachable.md — from template
CREATED .claude/commands/broadcast-chat.md — from template
CREATED .claude/commands/check-arc.md — from template
CREATED .claude/commands/conversations.md — from template
CREATED .claude/commands/peers.md — from template
CREATED .claude/commands/pulse.md — from template
CREATED .claude/commands/recent-chat.md — from template
CREATED .claude/commands/recent-dm.md — from template
CREATED scripts/agent-chat-arc-recent.sh — from template
... (twelve scripts in all)
The same 21 files come back on every upgrade after being removed.
fw doctor output
AI Agent
Claude Code
Operating System
Linux
Additional Context
Version: 1.8.6 (1ea10441f), vendored consumer. First seen on 1.8.3.
Small inconsistency: fw upgrade --help announces "scripts/doorbell+mail supporting toolkit (11 .sh)"; twelve are installed.
Suggestions:
- Make the toolkit opt-in (config key or
--with-messaging), or at least skippable, and remember the choice. - Skip the step when TermLink is absent.
- Do not create a project-root
scripts/directory, which collides with a very common project folder name; keep the scripts under.agentic-framework/. - Say in the upgrade summary that these files enable cross-host communication.
- Lingua principale
- Shell
- Stelle
- 16
- Fork
- 6
- Merge medio
- 6h 24m
- PR unite (30g)
- 5
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di DimitriGeelen/agentic-engineering-framework
-
area:cli bug severity:low status:fixed-on-bleeding-edge triaged
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
DimitriGeelen/agentic-engineering-framework#100 · 5 commenti ·
-
area:cli bug severity:medium status:fixed-on-bleeding-edge triaged
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
DimitriGeelen/agentic-engineering-framework#97 · 5 commenti ·
-
area:context bug severity:low status:fixed-on-bleeding-edge triaged
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
DimitriGeelen/agentic-engineering-framework#96 · 5 commenti ·
-
area:docs bug severity:medium status:in-progress triaged
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
DimitriGeelen/agentic-engineering-framework#95 · 4 commenti ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 64/100
Tutte le issue di DimitriGeelen/agentic-engineering-framework
Issue simili
-
Security: Vulnerable PHP version (CVE-2026-109618 / CVE-2026-109619) in current Docker imagesAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
MISP/misp-docker#478 ·
I maintainer di solito rispondono entro 1 giorno
-
roadmap-100
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
I maintainer di solito rispondono entro 1 giorno
-
priority: medium status: needs-decision work-class: scoped
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
melodic-software/claude-code-plugins#9339 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
Theme switch hangs in omarchy-theme-set-browser when Brave Origin runs and brave-bin is installedAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
数据界面的横向滚动条缺失Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
zilliztech/attu#1037 ·