Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Sovereignty: fw task review emits a hardcoded 'go' verb next to a NO-GO rationale

Aperta
  • Qualcosa non va?
#82 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
54/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
shell
Ambito
cli, developer-experience

Direzione di ricerca

Read lib/review.sh at emit_review and lib/inception.sh around line 401 for the accepted decision verbs. Check how recommendation lines are extracted and how the existing verb validation handles an inert placeholder; then run or recreate the reported fixture cases, including absent and unclassifiable recommendations. Done means the emitted command does not prescribe a decision that contradicts the recommendation and remains safely rejected when it cannot classify one.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Context

  • Framework version: 1.6.258
  • Project: 050-email-archive (shared-tooling mode)
  • Reported: 2026-09-28T17:35:47Z

Description

emit_review in lib/review.sh prints a copy-pasteable decision command for every inception task. The verb is a string literal go, while --rationale is interpolated from the task's own **Recommendation:** line:

echo "    $(_fw_cmd) inception decide $task_id go \\"
echo "    --rationale \"${_rec_line}\""

So an inception recommending NO-GO hands the human a ready-to-paste command that RECORDS GO carrying a rationale that reads NO-GO. The rationale is what lands in the audit record, so the artefact contradicts itself. This is a sovereignty boundary: the verb is the human's decision, and the tool pre-fills it wrongly.

MEASURED BLAST RADIUS (two independent consumer projects):

  • 050-email-archive: 48 of 116 inception tasks carrying a recommendation (41%) emit the contradiction — 16 NO-GO, 32 DEFER. A further 21 tasks have no recommendation line at all and got go beside the placeholder rationale 'your rationale'.
  • 010-termlink measured 51 of 245 independently.

SUGGESTED FIX: derive the verb from the recommendation's LEADING token, anchored rather than substring-matched, and refuse to guess otherwise. go | no-go | defer is already the accepted vocabulary (lib/inception.sh:401), so all three classes map exactly and nothing is invented.

Anchoring matters in BOTH directions: 'NO-GO' contains 'GO', and prose like 'Do not go ahead until X' contains 'GO' while meaning the opposite. A substring test gets both wrong.

When the recommendation is absent or unclassifiable, emit an inert placeholder token rather than a verb. Note that <go|no-go> is a poor placeholder: pasted into bash it is a stdin redirect plus a pipe, so it fails messily for the wrong reason. A bare uppercase token like DECISION is shell-inert and is rejected cleanly by the existing verb check.

We have applied this locally as a vendored patch and pinned it with a 21-assertion fixture suite that drives the real emit_review (including a negative control sourcing the pre-fix version from git, and a live-corpus pass over all 137 inception tasks). Happy to raise a PR if useful.

Reported via fw upstream report from field installation

Lingua principale
Shell
Stelle
16
Fork
6
Merge medio
6h 24m
PR unite (30g)
5

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di DimitriGeelen/agentic-engineering-framework

Tutte le issue di DimitriGeelen/agentic-engineering-framework

Issue simili

Altre issue su Shell/Bash

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.