Maven adapter: fewer full-suite fallbacks (tracking issue)

Aperta
#89 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
Più di una settimana
Idoneità per principianti
45/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
java, typescript
Ambito
build-system

Direzione di ricerca

Start in src/repo/adapters/maven.ts, where the adapter decides when to record a blockers entry and fall back to the full suite, and read the Maven table in docs/using-diffci.md that lists each fallback. Pick one unchecked step, such as custom sourceDirectory roots, and confirm the current fallback path before changing it. Done means that case no longer falls back, the blocker is gone, and the docs table is updated in the same change.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

adapter enhancement help wanted

DiffCI works out what a change needs from CI, starting with the tests it affects, so AI coding agents (and people) can run them before pushing. Conventional Maven reactors are supported today (src/repo/adapters/maven.ts), but some real Maven repositories still fall back to the full suite. This issue tracks closing those fallbacks, and it's open for contributors and design partners.

Today a Maven repository runs the full suite when it:

  • sets custom source roots (<sourceDirectory> or <testSourceDirectory> other than the defaults)
  • inherits dependencies from an external parent POM
  • uses a ${property} dependency version DiffCI can't resolve
  • has a reactor with no Java sources (resources only)

Steps (each is one PR; take any that are unblocked):

  • Follow custom <sourceDirectory> and <testSourceDirectory> roots
  • Resolve dependencies inherited from an external parent POM (from the local repository, or mvn help:effective-pom output when available)
  • Resolve ${property} versions from the POM chain and -D / .mvn/maven.config
  • Replay on one public Maven repository and publish the report

Gradle is separate: #68.

Ground rules

  • When the adapter is unsure, it records a blockers entry and DiffCI runs the full suite. An empty graph must never look like "nothing affected".
  • Every fallback is listed under "Maven" in docs/using-diffci.md. A PR that removes one updates that table.
  • Discuss design questions here, so every step stays consistent.

Have a Maven repository that falls back today? Run npx --yes @diffci.com/diffci@latest check --base origin/main --head HEAD and post the fallback reason below. Real repositories decide the order.

Lingua principale
TypeScript
Stelle
0
Fork
4
Merge medio
18h 41m
PR unite (30g)
48

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di DiffCI/core

Tutte le issue di DiffCI/core

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.